Issue 9207012: Pepper/Flapper: Add C++ wrappers for PPB_Flash_Clipboard.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9207012: Pepper/Flapper: Add C++ wrappers for PPB_Flash_Clipboard. (Closed)

Created:
8 years, 11 months ago by viettrungluu

Modified:
8 years, 11 months ago

Reviewers:
dmichael (off chromium), yzshen1, piman

CC:
chromium-reviews, dcheng

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Pepper/Flapper: Add C++ wrappers for PPB_Flash_Clipboard. This makes the interface a bit easier to use and, more importantly, easier to update the interface while maintaining suitable compatibility. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117750

Patch Set 1 #

Total comments: 1

Patch Set 2 : pp::flash::FlashClipboard -> pp::flash::Clipboard #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+120 lines, -0 lines)			Patch
A	ppapi/cpp/private/flash_clipboard.h	View	1	1 chunk	+43 lines, -0 lines	0 comments	Download
A	ppapi/cpp/private/flash_clipboard.cc	View	1	1 chunk	+75 lines, -0 lines	0 comments	Download
M	ppapi/ppapi_sources.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

yzshen1

lgtm Only one nit http://codereview.chromium.org/9207012/diff/1/ppapi/cpp/private/flash_clipboard.h File ppapi/cpp/private/flash_clipboard.h (right): http://codereview.chromium.org/9207012/diff/1/ppapi/cpp/private/flash_clipboard.h#newcode18 ppapi/cpp/private/flash_clipboard.h:18: class FlashClipboard { I think ...

8 years, 11 months ago (2012-01-13 22:08:09 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/9207012/6002

8 years, 11 months ago (2012-01-13 23:51:45 UTC) #4

Change committed as 117750

Expand Messages | Collapse Messages