Issue 92064: Check the size of bitmaps coming over IPC....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 92064: Check the size of bitmaps coming over IPC.... (Closed)

Created:
11 years, 8 months ago by abarth-chromium

Modified:
9 years, 7 months ago

Reviewers:
cpu_(ooo_6.6-7.5)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Check the size of bitmaps coming over IPC. R=cpu BUG=10869 TEST=IPCMessageTest.Bitmap Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14398

Patch Set 1 #

Total comments: 1

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -3 lines)			Patch
	M	chrome/common/ipc_message_unittest.cc	View		2 chunks	+45 lines, -0 lines	0 comments	Download
	M	chrome/common/ipc_message_utils.cc	View		2 chunks	+6 lines, -3 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

cpu_(ooo_6.6-7.5)

11 years, 8 months ago (2009-04-23 16:58:23 UTC) #2

LGTM  w/ comment below.

http://codereview.chromium.org/92064/diff/1/2
File chrome/common/ipc_message_utils.cc (right):

http://codereview.chromium.org/92064/diff/1/2#newcode41
Line 41: bitmap->allocPixels();
can you check for the return value fo allocPixels()?

Expand Messages | Collapse Messages