Implement input type=color UI

chrome/browser/ui/views/color_chooser_dialog_win.cc

Index: chrome/browser/ui/views/color_chooser_dialog_win.cc
diff --git a/chrome/browser/ui/views/color_chooser_dialog_win.cc b/chrome/browser/ui/views/color_chooser_dialog_win.cc
new file mode 100644
index 0000000000000000000000000000000000000000..a84153a882032b8110d5fc457d804033e7b78070
--- /dev/null
+++ b/chrome/browser/ui/views/color_chooser_dialog_win.cc
@@ -0,0 +1,85 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/views/color_chooser_dialog_win.h"
+
+#include <commdlg.h>
+
+#include "base/bind.h"
+#include "base/message_loop.h"
+#include "content/public/browser/browser_thread.h"
+#include "skia/ext/skia_utils_win.h"
+
+using content::BrowserThread;
+
+ColorChooserDialogWin::ColorChooserDialogWin(Listener* listener)
+    : listener_(listener),
+      ColorChooserDialog(),
+      BaseShellDialogImpl() {
+  DCHECK(listener_);
+}
+
+ColorChooserDialogWin::~ColorChooserDialogWin() {
+}
+
+bool ColorChooserDialogWin::IsRunning(HWND owning_hwnd) const {
+  return listener_ && IsRunningDialogForOwner(owning_hwnd);
+}
+
+void ColorChooserDialogWin::ListenerDestroyed() {
+  // Our associated listener has gone away, so we shouldn't call back to it if
+  // our worker thread returns after the listener is dead.
+  listener_ = NULL;
+}
+
+void ColorChooserDialogWin::SelectColor(SkColor initial_color,
+                                         gfx::NativeWindow owning_window) {
+  ExecuteOpenParams execute_params(initial_color, BeginRun(owning_window),
+                                   owning_window);
+  execute_params.run_state.dialog_thread->message_loop()->PostTask(FROM_HERE,
+    base::Bind(&ColorChooserDialogWin::ExecuteOpen, this, execute_params));

[Peter Kasting, 2012/02/07 01:46:24]

Nit: Indent 4

[keishi, 2012/02/17 11:31:05]

Done.

+}
+
+void ColorChooserDialogWin::ExecuteOpen(const ExecuteOpenParams& params) {
+  COLORREF color = skia::SkColorToCOLORREF(params.color);
+  CHOOSECOLOR cc;
+  cc.lStructSize = sizeof(CHOOSECOLOR);
+  cc.hwndOwner = params.owner;
+  cc.rgbResult = color;
+  cc.lpCustColors = custom_colors_;

[Peter Kasting, 2012/02/07 01:46:24]

Pointing at a member isn't going to be very useful because this dialog object
won't live past this invocation.  Instead we should probably point at some piece
of storage that's owned by the window?  (Pointing at a global might be dangerous
because who knows what could happen if two different color choosers try to
access it simultaneously.)

+  cc.Flags = CC_FULLOPEN | CC_RGBINIT;

[Peter Kasting, 2012/02/07 01:46:24]

Nit: Do you need to set CC_ANYCOLOR?  (What difference does that flag make,
anyway?)

[keishi, 2012/02/17 11:31:05]

Seems like the original purpose was to show all colors including dithered
colors. Added it anyway.

+  bool success = !!ChooseColor(&cc);
+  DisableOwner(cc.hwndOwner);
+  if (success) {
+    BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
+        base::Bind(&ColorChooserDialogWin::DidChooseColor, this,
+                   skia::COLORREFToSkColor(cc.rgbResult),
+                   params.run_state));
+  } else {
+    BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
+        base::Bind(&ColorChooserDialogWin::DidDetach, this,
+                   params.run_state));
+  }
+}
+
+void ColorChooserDialogWin::DidChooseColor(SkColor color,
+                                       RunState run_state) {
+  if (!listener_)
+    return;
+  EndRun(run_state);
+  listener_->DidChooseColor(color);
+  listener_->DidEnd();
+}
+
+void ColorChooserDialogWin::DidDetach(RunState run_state) {
+  if (!listener_)
+    return;
+  EndRun(run_state);
+  listener_->DidEnd();
+}
+
+// static
+ColorChooserDialog* ColorChooserDialog::Create(Listener* listener) {
+  return new ColorChooserDialogWin(listener);
+}