Implement input type=color UI

content/public/browser/color_chooser.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_PUBLIC_BROWSER_COLOR_CHOOSER_H_
+#define CONTENT_PUBLIC_BROWSER_COLOR_CHOOSER_H_
+#pragma once
+
+#include "third_party/skia/include/core/SkColor.h"
+
+class RenderViewHost;
+
+namespace content {
+
+class WebContents;
+
+// Abstraction object for color choosers for each platforms.

[Peter Kasting, 2012/03/01 20:44:18]

Nit: platforms -> platform

[keishi, 2012/03/02 06:12:13]

Done.

+class ColorChooser {
+ public:
+  static ColorChooser* Create(
+      int identifier, WebContents* tab, SkColor initial_color);

[Peter Kasting, 2012/03/01 20:44:18]

Nit: One arg per line, first arg on above line, others indented even

[keishi, 2012/03/02 06:12:13]

Done.

+
+  virtual ~ColorChooser() {}
+
+  // Returns the color chooser id that is unique per renderer process.

[Peter Kasting, 2012/03/01 20:44:18]

Nit: How about providing more motivation for this ID, a la:

  // Returns a unique identifier for this chooser.  Identifiers are unique
  // across a renderer process.  This avoids race conditions in synchronizing
  // the browser and renderer processes.  For example, if a renderer closes one
  // chooser and opens another, and simultaneously the user picks a color in the
  // first chooser, the IDs can be used to drop the "chose a color" message
  // rather than erroneously tell the renderer that the user picked a color in
  // the second chooser.

[keishi, 2012/03/02 06:12:13]

Done.

+  virtual int GetIdentifier() const = 0;

[Peter Kasting, 2012/03/01 20:44:18]

This doesn't need to be virtual.  All three subclasses implement this the same
way, by returning |identifier_|.  Instead, make |identifier_| a private member
of this class and add an explicit one-arg constructor to set it; then make this
function a unix_hacker()-style inlined const getter.

[keishi, 2012/03/02 06:12:13]

Done.

+
+  // Ends connection with color chooser. Closes color chooser depending on the
+  // platform.
+  virtual void End() = 0;
+
+  // Sets the selected color.
+  virtual void SetSelectedColor(SkColor color) = 0;
+};
+
+}
+
+#endif  // CONTENT_PUBLIC_BROWSER_COLOR_CHOOSER_H_