chrome/browser/ui/color_chooser.h - Issue 9203001: Implement input type=color UI

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/color_chooser.h

Issue 9203001: Implement input type=color UI (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: fixed Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_UI_COLOR_CHOOSER_H_

	6 #define CHROME_BROWSER_UI_COLOR_CHOOSER_H_

	7 #pragma once

	8

	9 #include "content/public/browser/color_chooser.h"

	10

	11 namespace content {

	12 class WebContents;

	13 }

	14

	15 // Abstraction object for color choosers for each platforms.

	16 class ColorChooser : public content::ColorChooser {
	Peter Kasting 2012/02/29 01:40:07 Why do you need this second abstraction layer? Wh Why do you need this second abstraction layer? Why can't the Create() function here be declared in the content header with the rest of content::ColorChooser, and eliminate this class entirely? keishi 2012/02/29 13:05:22 I was thinking that too. Removed ColorChooser clas Show quoted text On 2012/02/29 01:40:07, Peter Kasting wrote: > Why do you need this second abstraction layer? Why can't the Create() function > here be declared in the content header with the rest of content::ColorChooser, > and eliminate this class entirely? I was thinking that too. Removed ColorChooser class.
	17 public:

	18 static ColorChooser* Create(

	19 int identifier, content::WebContents* tab, SkColor initial_color);

	20 };

	21

	22 #endif // CHROME_BROWSER_UI_COLOR_CHOOSER_H_

OLD	NEW