Implement input type=color UI

content/renderer/renderer_webcolorchooser_impl.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/renderer/renderer_webcolorchooser_impl.h"
+
+#include "content/common/view_messages.h"
+#include "content/renderer/render_view_impl.h"
+
+static unsigned generateColorChooserIdentifier() {

[jam, 2012/02/22 02:55:20]

nit: GenerateColorChooserIdentifier

[keishi, 2012/02/24 14:38:54]

Done.

+    static unsigned next = 0;

[jam, 2012/02/22 02:55:20]

nit: 2 space indents per chrome C++ style guide

[keishi, 2012/02/24 14:38:54]

Done.

+    return ++next;
+}
+
+RendererWebColorChooserImpl::RendererWebColorChooserImpl(
+    RenderViewImpl* render_view, WebKit::WebColorChooserClient* client)
+    : content::RenderViewObserver(render_view),
+      identifier_(generateColorChooserIdentifier()),
+      client_(client) {
+}
+
+RendererWebColorChooserImpl::~RendererWebColorChooserImpl() {
+}
+
+bool RendererWebColorChooserImpl::OnMessageReceived(
+    const IPC::Message& message) {
+  bool handled = true;
+  IPC_BEGIN_MESSAGE_MAP(RendererWebColorChooserImpl, message)
+    IPC_MESSAGE_HANDLER(ViewMsg_DidChooseColorResponse,
+                        OnDidChooseColorResponse)
+    IPC_MESSAGE_HANDLER(ViewMsg_DidEndColorChooser,
+                        OnDidEndColorChooser)
+    IPC_MESSAGE_UNHANDLED(handled = false)
+  IPC_END_MESSAGE_MAP()
+  return handled;
+}
+
+void RendererWebColorChooserImpl::FrameWillClose(WebKit::WebFrame* frame) {
+  endChooser();
+}
+
+void RendererWebColorChooserImpl::setSelectedColor(WebKit::WebColor color) {
+  Send(new ViewHostMsg_SetSelectedColorInColorChooser(routing_id(), identifier_,
+      static_cast<SkColor>(color)));
+}
+
+void RendererWebColorChooserImpl::endChooser() {
+  Send(new ViewHostMsg_EndColorChooser(routing_id(), identifier_));
+  if (client_.get())
+    client_->didEndChooser();

[jam, 2012/02/22 02:55:20]

I don't see the webkit side giving NULL pointers, so why do you null check
everywhere?

also it's a little odd from an API design that this object deletes its delegate.
i haven't seen that before with WebKit API, did Darin review that?

[keishi, 2012/02/24 14:38:54]

OK. Removed all checks.
Sorry. I shouldn't have used a scoped_ptr for client_.
The ColorChooserClient calls createColorChooser so it is the owner of the
ColorChooser.

+}
+
+void RendererWebColorChooserImpl::Open(SkColor initial_color) {
+  Send(new ViewHostMsg_OpenColorChooser(routing_id(), identifier_,
+                                        initial_color));
+  if (client_.get())
+    client_->didEndChooser();
+}
+
+void RendererWebColorChooserImpl::OnDidChooseColorResponse(
+    int color_chooser_id,
+    const SkColor& color) {
+  if (identifier_ != color_chooser_id)

[jam, 2012/02/22 02:55:20]

is this a race condition that you sent the picture of?

[keishi, 2012/02/24 14:38:54]

No, it's for another race condition. But this race condition is less likely to
occur because the user has to click another input element while the
ViewMsg_DidChooseColorResponse message is in the queue.

[jam, 2012/02/24 21:41:17]

Are you sure that's a race condition that can occur? If the user input event
that causes the color picker to be hidden is in the renderer's IPC queue, won't
that necessarily arrive before the input event that clicks on a different color
picker?

From what I understand on Mac and Linux the touch picker is non-modal, while on
Windows it's modal because of a system constraint. But even on Mac/Linux, can
there be more than one color picker visible at the same time on a page? I'd like
to understand this better to know whether we need these color_chooser_ids.

+    return;
+  if (client_.get())
+    client_->didChooseColor(static_cast<WebKit::WebColor>(color));
+}
+
+void RendererWebColorChooserImpl::OnDidEndColorChooser(
+    int color_chooser_id) {
+  if (identifier_ != color_chooser_id)
+    return;
+  if (client_.get())
+    client_->didEndChooser();
+}
+
+WebKit::WebColorChooserClient* RendererWebColorChooserImpl::client() {
+  return client_.get();
+}