Implement input type=color UI

content/public/browser/web_contents_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_DELEGATE_H_
 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_DELEGATE_H_
 #pragma once
 
 #include <set>
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/string16.h"
 #include "content/common/content_export.h"
 #include "content/public/browser/navigation_type.h"
 #include "content/public/common/page_transition_types.h"
 #include "content/public/common/window_container_type.h"
+#include "third_party/skia/include/core/SkColor.h"
 #include "ui/gfx/native_widget_types.h"
 #include "webkit/glue/window_open_disposition.h"
 
 class FilePath;
 class GURL;
 class TabContents;
 struct NativeWebKeyboardEvent;
 
 namespace base {
 class ListValue;
@@ skipping 272 matching lines @@
 
   // Invoked when navigating to a pending entry. When invoked the
   // NavigationController has configured its pending entry, but it has not yet
   // been committed.
   virtual void DidNavigateToPendingEntry(WebContents* tab) {}
 
   // Returns a pointer to a service to create JavaScript dialogs. May return
   // NULL in which case dialogs aren't shown.
   virtual JavaScriptDialogCreator* GetJavaScriptDialogCreator();
 
+  // Called when color chooser should open.
+  virtual void OpenColorChooser(WebContents* tab,
+                                int color_chooser_id,
+                                const SkColor& color) {}
+
+  // Called when color chooser should end.
+  virtual void EndColorChooser(WebContents* tab, int color_chooser_id) {}

[jam, 2012/02/22 02:55:20]

it seems that this method and the one below are properties on the color chooser
object and not the delegate.

can we make a small interface (in content/public/browser) that the embedder
returns as a return value to OpenColorChooser? i.e. content::ColorChooser. it
can then have these two methods on it. 

[keishi, 2012/02/24 14:38:54]

If I were to add content::ColorChooser interface, what should implement it?
Should TabContents keep the returned pointer from OpenColorChooser as a member?

I don't want multiple color chooser dialogs open at the same time, so I want to
close the currently open one when opening a new one.

This patch keeps the pointer to the currently open ColorChooser in the Browser
object but I don't think it's a good place to keep it.
Could you recommend a better place (I think maybe a singleton object) to keep
this pointer ?

[jam, 2012/02/24 21:41:17]

whichever code that implements EndColorChooser/SetSelectedColorInColorChooser
now (i.e. your ColorChooser class).
yes
if that's the case, then do you really need these color_chooser_ids?
singleton might mean that there is only one per process. i dont know when these
color chooser UIs go away on all platforms. will they stay open on mac/linux
when a user switches tabs or clicks on another chrome window? if so there could
be multiple per process, in which case a singleton wouldn't work. if there's
only one per tab, then on the TabContents seems fine.

+
+  // Called when the selected color in color chooser should change.
+  virtual void SetSelectedColorInColorChooser(WebContents* tab,
+                                              int color_chooser_id,
+                                              const SkColor& color) {}
+
   // Called when a file selection is to be done.
   virtual void RunFileChooser(WebContents* tab,
                               const FileChooserParams& params) {}
 
   // Request to enumerate a directory.  This is equivalent to running the file
   // chooser in directory-enumeration mode and having the user select the given
   // directory.
   virtual void EnumerateDirectory(WebContents* tab,
                                   int request_id,
                                   const FilePath& path) {}
@@ skipping 68 matching lines @@
   // Called when |this| is no longer the WebContentsDelegate for |source|.
   void Detach(WebContents* source);
 
   // The WebContents that this is currently a delegate for.
   std::set<WebContents*> attached_contents_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_DELEGATE_H_