Implement input type=color UI

chrome/browser/ui/color_chooser_dialog.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_COLOR_CHOOSER_DIALOG_H_
+#define CHROME_BROWSER_UI_COLOR_CHOOSER_DIALOG_H_
+#pragma once
+
+#include "base/memory/ref_counted.h"
+#include "chrome/browser/ui/base_shell_dialog.h"
+#include "third_party/skia/include/core/SkColor.h"
+
+// Shows a dialog for choosing color.
+class ColorChooserDialog

[Peter Kasting, 2012/02/07 01:46:24]

ColorChooserDialogWin is the only implementer of this class.  Seems like the two
should just be combined into a single class definition.

[keishi, 2012/02/17 11:31:05]

Done.

+    : public base::RefCountedThreadSafe<ColorChooserDialog>,
+      public BaseShellDialog {
+ public:
+  // An interface implemented by a Listener object wishing to know about the
+  // the results from the color chooser dialog.
+  class Listener {
+   public:
+    virtual ~Listener {}
+    virtual void DidChooseColor(SkColor color) = 0;
+    virtual void DidEnd() = 0;
+  };
+
+  // Creates a dialog box helper. This object is ref-counted, but the returned
+  // object will have no reference (refcount is 0).
+  static ColorChooserDialog* Create(Listener* listener);

[Peter Kasting, 2012/02/07 01:46:24]

Nit: The combined class can just use a standard constructor since there's no
platform-independence benefit from running a Create() function.

[keishi, 2012/02/17 11:31:05]

Done.

+
+  // Opens the color chooser dialog.
+  virtual void SelectColor(SkColor initial_color,
+                   gfx::NativeWindow owning_window) = 0;

[Peter Kasting, 2012/02/07 01:46:24]

Nit: Why aren't these args to the constructor instead?

[keishi, 2012/02/17 11:31:05]

Done.

+
+  explicit ColorChooserDialog() { }

[Peter Kasting, 2012/02/07 01:46:24]

Nit: Don't use "explicit" on no-arg constructor forms.  No spaces between {}.

[keishi, 2012/02/17 11:31:05]

Done.

+
+  DISALLOW_COPY_AND_ASSIGN(ColorChooserDialog);
+};
+
+#endif  // CHROME_BROWSER_UI_COLOR_CHOOSER_DIALOG_H_