Implement input type=color UI

chrome/browser/ui/color_chooser.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_COLOR_CHOOSER_H_
+#define CHROME_BROWSER_UI_COLOR_CHOOSER_H_
+#pragma once
+
+#include "third_party/skia/include/core/SkColor.h"
+#include "ui/gfx/native_widget_types.h"
+
+class RenderViewHost;
+
+// Abstraction object for color choosers of each platforms.

[Peter Kasting, 2012/02/07 01:46:24]

Nit: "of each platforms" -> "for each platform"

[keishi, 2012/02/17 11:31:05]

Done.

+class ColorChooser {
+ public:
+  static ColorChooser* Create(unsigned identifier, RenderViewHost*);

[Peter Kasting, 2012/02/07 01:46:24]

Nit: "unsigned" is banned by the style guide.  Use int or size_t depending on
whether you want "generic numeric identifier" or "count of objects in
memory-based container".

Also, name all arguments.

[keishi, 2012/02/17 11:31:05]

Done.

+  virtual ~ColorChooser() {}
+
+  virtual RenderViewHost* render_view_host() = 0;
+  virtual unsigned identifier() = 0;
+
+  virtual void Open(SkColor initial_color) = 0;

[Peter Kasting, 2012/02/07 01:46:24]

Nit: Why isn't this an arg to the constructor instead?

[keishi, 2012/02/17 11:31:05]

Done.

+  virtual void End() = 0;
+  virtual void SetSelectedColor(SkColor color) = 0;
+};
+
+#endif  // CHROME_BROWSER_UI_COLOR_CHOOSER_H_