Implement input type=color UI

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 #include <string>
 #include <vector>
@@ skipping 56 matching lines @@
 #include "content/renderer/notification_provider.h"
 #include "content/renderer/p2p/socket_dispatcher.h"
 #include "content/renderer/plugin_channel_host.h"
 #include "content/renderer/render_audiosourceprovider.h"
 #include "content/renderer/render_process.h"
 #include "content/renderer/render_thread_impl.h"
 #include "content/renderer/render_widget_fullscreen_pepper.h"
 #include "content/renderer/renderer_accessibility.h"
 #include "content/renderer/renderer_gpu_video_decoder_factories.h"
 #include "content/renderer/renderer_webapplicationcachehost_impl.h"
+#include "content/renderer/renderer_webcolorchooser_impl.h"
 #include "content/renderer/renderer_webstoragenamespace_impl.h"
 #include "content/renderer/speech_input_dispatcher.h"
 #include "content/renderer/text_input_client_observer.h"
 #include "content/renderer/v8_value_converter_impl.h"
 #include "content/renderer/web_ui_bindings.h"
 #include "content/renderer/webplugin_delegate_proxy.h"
 #include "content/renderer/websharedworker_proxy.h"
 #include "media/base/filter_collection.h"
 #include "media/base/media_switches.h"
 #include "media/base/message_loop_factory_impl.h"
@@ skipping 280 matching lines @@
       cached_has_main_frame_horizontal_scrollbar_(false),
       cached_has_main_frame_vertical_scrollbar_(false),
       ALLOW_THIS_IN_INITIALIZER_LIST(cookie_jar_(this)),
       geolocation_dispatcher_(NULL),
       speech_input_dispatcher_(NULL),
       device_orientation_dispatcher_(NULL),
       media_stream_dispatcher_(NULL),
       p2p_socket_dispatcher_(NULL),
       devtools_agent_(NULL),
       renderer_accessibility_(NULL),
+      color_chooser_(NULL),
       session_storage_namespace_id_(session_storage_namespace_id),
       handling_select_range_(false),
 #if defined(OS_WIN)
       focused_plugin_id_(-1),
 #endif
       ALLOW_THIS_IN_INITIALIZER_LIST(pepper_delegate_(this)) {
   routing_id_ = routing_id;
   surface_id_ = surface_id;
   if (opener_id != MSG_ROUTING_NONE)
     opener_id_ = opener_id;
@@ skipping 1214 matching lines @@
     // seems safest to not execute the rest.
     if (!frame->executeCommand(WebString::fromUTF8(it->name),
                                WebString::fromUTF8(it->value)))
       break;
     did_execute_command = true;
   }
 
   return did_execute_command;
 }
 
+WebKit::WebColorChooser* RenderViewImpl::createColorChooser(
+    WebKit::WebColorChooserClient* client,
+    const WebKit::WebColor& initial_color) {
+  if (color_chooser_)
+    color_chooser_->endChooser();
+  color_chooser_ = new RendererWebColorChooserImpl(this, client);
+  Send(new ViewHostMsg_OpenColorChooser(routing_id_, initial_color));
+  return static_cast<WebKit::WebColorChooser*>(color_chooser_);
+}
+
+void RenderViewImpl::endColorChooser() {

[jam, 2012/01/27 18:13:40]

I don't think this function is needed.

The colorchooser object can watch ClosePage through the RenderViewObserver
interface and delete itself then. it doesn't need to call RVImpl. then the
latter doesn't need to store a pointer to it.

[keishi, 2012/02/06 15:01:57]

This pointer was used to end the ColorChooser inside WebKit inside the open call
so that there isn't two RendererWebColorChooserImpl instances at the same time.
Two remove this pointer and to make the code more robust I introduced color
chooser ids in my new patch.

[jam, 2012/02/07 02:51:46]

Perhaps I wasn't clear. I don't think this is needed because when WebKit wants
to end the color chooser, it currently calls
RendererWebColorChooserImpl::endChooser(). Now this turns around and calls
RenderViewImpl::endChooser, which RVI now needs to reset the pointer it's
holding on to. But why is it holding on to the pointer in the first place? It
looks like you do that so that you can call it in OnShouldClose and to avoid
having two objects per RenderViewImpl. For the first use case, you can watch
ClosePage through RenderViewObserver. For the second, you can derive from the
RenderViewObserverTracker template which will allow you to find if there are any
instances.

+  color_chooser_ = NULL;
+}
+
 bool RenderViewImpl::runFileChooser(
     const WebKit::WebFileChooserParams& params,
     WebFileChooserCompletion* chooser_completion) {
   // Do not open the file dialog in a hidden RenderView.
   if (is_hidden())
     return false;
   content::FileChooserParams ipc_params;
   if (params.directory)
     ipc_params.mode = content::FileChooserParams::OpenFolder;
   else if (params.multiSelect)
@@ skipping 2483 matching lines @@
 
   WebPageSerializer::serialize(webview()->mainFrame(), true, this, weburl_links,
                                webstring_paths,
                                webkit_glue::FilePathToWebString(
                                    local_directory_name));
 }
 
 void RenderViewImpl::OnShouldClose() {
   bool should_close = webview()->dispatchBeforeUnloadEvent();
   Send(new ViewHostMsg_ShouldClose_ACK(routing_id_, should_close));
+  if (color_chooser_)
+    color_chooser_->endChooser();
 }
 
 void RenderViewImpl::OnSwapOut(const ViewMsg_SwapOut_Params& params) {
   if (is_swapped_out_)
     return;
 
   // Swap this RenderView out so the tab can navigate to a page rendered by a
   // different process.  This involves running the unload handler and clearing
   // the page.  Once WasSwappedOut is called, we also allow this process to exit
   // if there are no other active RenderViews in it.
@@ skipping 791 matching lines @@
 bool RenderViewImpl::WebWidgetHandlesCompositorScheduling() const {
   return !!RenderThreadImpl::current()->compositor_thread();
 }
 
 void RenderViewImpl::OnJavaBridgeInit() {
   DCHECK(!java_bridge_dispatcher_.get());
 #if defined(ENABLE_JAVA_BRIDGE)
   java_bridge_dispatcher_.reset(new JavaBridgeDispatcher(this));
 #endif
 }