Implement input type=color UI

chrome/browser/color_select_observer.cc

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/color_select_observer.h"
+
+#include "chrome/browser/platform_util.h"
+#include "content/browser/renderer_host/render_view_host.h"
+#include "content/browser/renderer_host/render_widget_host_view.h"
+#include "content/browser/tab_contents/tab_contents.h"
+#include "content/common/view_messages.h"

[jam, 2012/01/17 06:49:55]

chrome can't include view_messages.h, since that's an internal  implementation
detail of content. unfortunately we can't turn on deps checking yet because
we're waiting for the last file to be moved to content (TabContentsViewMac).

so chrome layer doesn't filter content IPCs. instead, content notifies its
embedders through the use of existing interfaces like RenderViewHostDelegate or
WebContentsDelegate.

[keishi, 2012/01/27 04:34:08]

Done. I've made it go through TabContents and Browser.

+
+bool ColorSelectObserver::OnMessageReceived(const IPC::Message& message) {
+  bool handled = true;
+  IPC_BEGIN_MESSAGE_MAP(ColorSelectObserver, message)
+    IPC_MESSAGE_HANDLER(ViewHostMsg_OpenColorChooser, OnOpenColorChooser)
+    IPC_MESSAGE_HANDLER(ViewHostMsg_EndColorChooser, OnEndColorChooser)
+    IPC_MESSAGE_HANDLER(ViewHostMsg_SetSelectedColorInColorChooser,
+                        OnSetSelectedColorInColorChooser)
+    IPC_MESSAGE_UNHANDLED(handled = false)
+  IPC_END_MESSAGE_MAP()
+
+  return handled;
+}
+
+ColorSelectObserver::ColorSelectObserver(content::WebContents* web_contents)
+    : WebContentsObserver(web_contents) {
+}
+
+ColorSelectObserver::~ColorSelectObserver() {
+}
+
+void ColorSelectObserver::OnOpenColorChooser(
+    const ViewHostMsg_SetSelectedColorInColorChooser_Params& params) {
+  render_view_host_ = web_contents()->GetRenderViewHost();
+#if defined(OS_WIN)

[Peter Kasting, 2012/01/17 20:53:10]

As Ben noted, we shouldn't have bunches of #ifdefs in common code.  Think
carefully about what functionality truly needs to be platform-specific versus
what is merely defined for Windows because you haven't had the time or knowledge
to implement it for other platforms.  Hopefully the result is that most code can
be cross-platform with a few platform-specific bits separated out to separate
.cc files that live in the relevant ui/*/ subdirectories.

[keishi, 2012/01/27 04:34:08]

Done.

+  if (color_chooser_dialog_)
+    return;
+  gfx::NativeWindow owning_window =
+      platform_util::GetTopLevel(render_view_host_->view()->GetNativeView());
+  color_chooser_dialog_ = ColorChooserDialog::Create(this);
+  color_chooser_dialog_->SelectColor(params.color, owning_window);
+#else
+  ColorChooser::GetInstance()->open(this, params.color);
+#endif
+}
+
+void ColorSelectObserver::OnEndColorChooser() {
+#if !defined(OS_WIN)
+  if (render_view_host_ != web_contents()->GetRenderViewHost())
+    return;
+  ColorChooser::GetInstance()->end(this);
+#endif
+}
+
+void ColorSelectObserver::OnSetSelectedColorInColorChooser(
+    const ViewHostMsg_SetSelectedColorInColorChooser_Params& params) {
+#if !defined(OS_WIN)
+  ColorChooser::GetInstance()->setSelectedColor(params.color);
+#endif
+}
+
+void ColorSelectObserver::DidChooseColor(WebKit::WebColor color) {
+  render_view_host_->DidChooseColorInColorChooser(color);
+}
+
+void ColorSelectObserver::DidEnd() {
+  render_view_host_->DidEndColorChooser();
+#if defined(OS_WIN)
+  color_chooser_dialog_ = 0;
+#endif
+}