Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 92011: Add setting break points by using handles (Closed)

Created:
11 years, 8 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add setting break points by using handles. Extend the D8 break command to handle script names with :line[:column] position specification and handles using #<id>#. Committed: http://code.google.com/p/v8/source/detail?r=1770

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -8 lines) Patch
M src/d8.js View 1 2 chunks +35 lines, -2 lines 0 comments Download
M src/debug-delay.js View 2 chunks +17 lines, -2 lines 0 comments Download
M test/mjsunit/debug-setbreakpoint.js View 5 chunks +16 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Thygesen Gjesse
11 years, 8 months ago (2009-04-22 13:48:40 UTC) #1
Mads Ager (chromium)
LGTM http://codereview.chromium.org/92011/diff/1/3 File src/d8.js (right): http://codereview.chromium.org/92011/diff/1/3#newcode682 Line 682: print(column); Are the print calls in this ...
11 years, 8 months ago (2009-04-22 13:55:14 UTC) #2
Søren Thygesen Gjesse
11 years, 8 months ago (2009-04-22 13:59:15 UTC) #3
http://codereview.chromium.org/92011/diff/1/3
File src/d8.js (right):

http://codereview.chromium.org/92011/diff/1/3#newcode682
Line 682: print(column);
On 2009/04/22 13:55:15, Mads Ager wrote:
> Are the print calls in this function debugging output that should be removed?

Yes, thanks, removed.

Powered by Google App Engine
This is Rietveld 408576698