Issue 92009: When merging a frame to an expected on at block entry, the static type...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 92009: When merging a frame to an expected on at block entry, the static type... (Closed)

Created:
11 years, 8 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein, Dean McNamee, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

When merging a frame to an expected on at block entry, the static type of elements is set to a safe lower bound. Move the setting of the static type out of VirtualFrame::MergeTo (which is not necessarily run for all frames) and into VirtualFrame::PrepareMergeTo (which is). Committed: http://code.google.com/p/v8/source/detail?r=1767

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -1 line)			Patch
M	src/virtual-frame.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/virtual-frame-ia32.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
A	test/mjsunit/regress/regress-318.js	View		1 chunk	+35 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Dean McNamee

11 years, 8 months ago (2009-04-22 13:27:40 UTC) #4

http://codereview.chromium.org/92009/diff/1009/1012
File test/mjsunit/regress/regress-318.js (right):

http://codereview.chromium.org/92009/diff/1009/1012#newcode35
Line 35: assertDoesNotThrow(test(0));
Did you mean 'test(0)' ?

Expand Messages | Collapse Messages