Issue 92008: Small changes to improve test coverage in codegen-ia32.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 92008: Small changes to improve test coverage in codegen-ia32.cc. (Closed)

Created:
11 years, 8 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
iposva, Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Small changes to improve test coverage in codegen-ia32.cc. Committed: http://code.google.com/p/v8/source/detail?r=1769

Patch Set 1 #

Total comments: 2

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+96 lines, -31 lines)			Patch
M	src/codegen-ia32.cc	View	5 chunks	+31 lines, -31 lines	2 comments	Download
M	test/mjsunit/constant-folding.js	View	1 chunk	+36 lines, -0 lines	0 comments	Download
M	test/mjsunit/keyed-ic.js	View	1 chunk	+29 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

iposva

Drive by comment. -ip http://codereview.chromium.org/92008/diff/1/4 File src/codegen-ia32.cc (right): http://codereview.chromium.org/92008/diff/1/4#newcode1381 Line 1381: __ sar(answer.reg(), kSmiTagSize); Somehow ...

11 years, 8 months ago (2009-04-28 16:52:24 UTC) #3

Erik Corry

11 years, 8 months ago (2009-04-28 18:05:49 UTC) #4

http://codereview.chromium.org/92008/diff/1/4
File src/codegen-ia32.cc (right):

http://codereview.chromium.org/92008/diff/1/4#newcode1381
Line 1381: __ sar(answer.reg(), kSmiTagSize);
On 2009/04/28 16:52:24, iposva wrote:
> Somehow I feel this will never be reached, and I am not sure that you can
safely
> skip it.


Presumably you mean "and I am sure that".  It has been removed in a later
change.

Expand Messages | Collapse Messages