Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: net/http/http_byte_range_unittest.cc

Issue 92006: Implement a parser that parses the "Range" HTTP header... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_byte_range.cc ('k') | net/http/http_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_byte_range_unittest.cc
===================================================================
--- net/http/http_byte_range_unittest.cc (revision 0)
+++ net/http/http_byte_range_unittest.cc (revision 0)
@@ -0,0 +1,78 @@
+// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "net/http/http_byte_range.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+TEST(HttpByteRangeTest, ValidRanges) {
+ const struct {
+ int64 first_byte_position;
+ int64 last_byte_position;
+ int64 suffix_length;
+ bool valid;
+ } tests[] = {
+ { -1, -1, 0, false },
+ { 0, 0, 0, true },
+ { -10, 0, 0, false },
+ { 10, 0, 0, false },
+ { 10, -1, 0, true },
+ { -1, -1, -1, false },
+ { -1, 50, 0, false },
+ { 10, 10000, 0, true },
+ { -1, -1, 100000, true },
+ };
+
+ for (size_t i = 0; i < ARRAYSIZE_UNSAFE(tests); ++i) {
+ net::HttpByteRange range;
+ range.set_first_byte_position(tests[i].first_byte_position);
+ range.set_last_byte_position(tests[i].last_byte_position);
+ range.set_suffix_length(tests[i].suffix_length);
+ EXPECT_EQ(tests[i].valid, range.IsValid());
+ }
+}
+
+TEST(HttpByteRangeTest, SetInstanceSize) {
+ const struct {
+ int64 first_byte_position;
+ int64 last_byte_position;
+ int64 suffix_length;
+ int64 instance_size;
+ bool expected_return_value;
+ int64 expected_lower_bound;
+ int64 expected_upper_bound;
+ } tests[] = {
+ { -10, 0, -1, 0, false, -1, -1 },
+ { 10, 0, -1, 0, false, -1, -1 },
+ // Zero instance size is valid, this is the case that user has to handle.
+ { -1, -1, -1, 0, true, 0, -1 },
+ { -1, -1, 500, 0, true, 0, -1 },
+ { -1, 50, -1, 0, false, -1, -1 },
+ { -1, -1, 500, 300, true, 0, 299 },
+ { -1, -1, -1, 100, true, 0, 99 },
+ { 10, -1, -1, 100, true, 10, 99 },
+ { -1, -1, 500, 1000, true, 500, 999 },
+ { 10, 10000, -1, 1000000, true, 10, 10000 },
+ };
+
+ for (size_t i = 0; i < ARRAYSIZE_UNSAFE(tests); ++i) {
+ net::HttpByteRange range;
+ range.set_first_byte_position(tests[i].first_byte_position);
+ range.set_last_byte_position(tests[i].last_byte_position);
+ range.set_suffix_length(tests[i].suffix_length);
+
+ bool return_value = range.ComputeBounds(tests[i].instance_size);
+ EXPECT_EQ(tests[i].expected_return_value, return_value);
+ if (return_value) {
+ EXPECT_EQ(tests[i].expected_lower_bound, range.first_byte_position());
+ EXPECT_EQ(tests[i].expected_upper_bound, range.last_byte_position());
+
+ // Try to call SetInstanceSize the second time.
+ EXPECT_FALSE(range.ComputeBounds(tests[i].instance_size));
+ // And expect there's no side effect.
+ EXPECT_EQ(tests[i].expected_lower_bound, range.first_byte_position());
+ EXPECT_EQ(tests[i].expected_upper_bound, range.last_byte_position());
+ EXPECT_EQ(tests[i].suffix_length, range.suffix_length());
+ }
+ }
+}
« no previous file with comments | « net/http/http_byte_range.cc ('k') | net/http/http_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698