base/process_util_win.cc - Issue 9200009: windows: Fix a few things clang complains about.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/process_util_win.cc

Issue 9200009: windows: Fix a few things clang complains about. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/process_util_win.cc

diff --git a/base/process_util_win.cc b/base/process_util_win.cc

index dc165ec3889cace24d2172c2d91db8c3eb9653f5..573d80438bd88364ee80b3964325deff456770f7 100644

--- a/base/process_util_win.cc

+++ b/base/process_util_win.cc

@@ -592,7 +592,7 @@ bool WaitForProcessesToExit(const std::wstring& executable_name,

DWORD start_time = GetTickCount();

NamedProcessIterator iter(executable_name, filter);

- while (entry = iter.NextProcessEntry()) {

+ while ((entry = iter.NextProcessEntry())) {

Evan Martin 2012/01/23 18:19:49 Maybe add a != NULL here to make it more explicit?

Nico 2012/01/23 18:36:03 Sure, done.

DWORD remaining_wait =

std::max<int64>(0, wait_milliseconds - (GetTickCount() - start_time));

HANDLE process = OpenProcess(SYNCHRONIZE,