windows: Fix a few things clang complains about.

windows: Fix a few things clang complains about.

No functionality change.

BUG=82385
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118725

[Evan Martin, 2012-01-23 18:19:49]

http://codereview.chromium.org/9200009/diff/3002/base/file_util_win.cc
File base/file_util_win.cc (right):

http://codereview.chromium.org/9200009/diff/3002/base/file_util_win.cc#newcod...
base/file_util_win.cc:992: long result =
CompareFileTime(&find_info.ftLastWriteTime,  // NOLINT
Do you think the NOLINT bit here is related to your change?

http://codereview.chromium.org/9200009/diff/3002/base/process_util_win.cc
File base/process_util_win.cc (right):

http://codereview.chromium.org/9200009/diff/3002/base/process_util_win.cc#new...
base/process_util_win.cc:595: while ((entry = iter.NextProcessEntry())) {
Maybe add a != NULL here to make it more explicit?

http://codereview.chromium.org/9200009/diff/3002/base/win/sampling_profiler.cc
File base/win/sampling_profiler.cc (right):

http://codereview.chromium.org/9200009/diff/3002/base/win/sampling_profiler.c...
base/win/sampling_profiler.cc:107: base::LazyInstance<ProfilerFuncs,
base::LeakyLazyInstanceTraits<ProfilerFuncs> >
If the left one compiles already, shouldn't we be adapting Clang to support it
rather than changing the code?

[Nico, 2012-01-23 18:36:03]

http://codereview.chromium.org/9200009/diff/3002/base/file_util_win.cc
File base/file_util_win.cc (right):

http://codereview.chromium.org/9200009/diff/3002/base/file_util_win.cc#newcod...
base/file_util_win.cc:992: long result =
CompareFileTime(&find_info.ftLastWriteTime,  // NOLINT
On 2012/01/23 18:19:49, Evan Martin wrote:
> Do you think the NOLINT bit here is related to your change?

The CompareFileTime() call further up (line 67) in this file also has a NOLINT
annotation (and doesn't take the address of a temporary), so I thought it's not
related. Then again, maybe that line up there was copypasted from here.

Do we use any tools that look at this NOLINT these days?

http://codereview.chromium.org/9200009/diff/3002/base/process_util_win.cc
File base/process_util_win.cc (right):

http://codereview.chromium.org/9200009/diff/3002/base/process_util_win.cc#new...
base/process_util_win.cc:595: while ((entry = iter.NextProcessEntry())) {
On 2012/01/23 18:19:49, Evan Martin wrote:
> Maybe add a != NULL here to make it more explicit?

Sure, done.

http://codereview.chromium.org/9200009/diff/3002/base/win/sampling_profiler.cc
File base/win/sampling_profiler.cc (right):

http://codereview.chromium.org/9200009/diff/3002/base/win/sampling_profiler.c...
base/win/sampling_profiler.cc:107: base::LazyInstance<ProfilerFuncs,
base::LeakyLazyInstanceTraits<ProfilerFuncs> >
On 2012/01/23 18:19:49, Evan Martin wrote:
> If the left one compiles already, shouldn't we be adapting Clang to support it
> rather than changing the code?

In general, I think the upstream philosophy is to grudgingly accept what appears
in MS headers, and to prefer users to update their code to standard c++ instead.
(>> for templates is legal in c++11, but to get that one needs to pass
-std=c++11, which can change program semantics.) That also has the advantage
that it's easier to move code from _win files to shared files.

(It looks like '>>' -> '> >' is required only for the two files in this CL for
all of chrome, as far as I can tell.)

[Evan Martin, 2012-01-23 18:43:31]

great, LGTM

[Evan Martin, 2012-01-23 18:44:05]

On 2012/01/23 18:36:03, Nico wrote:
> Do we use any tools that look at this NOLINT these days?

(In case it wasn't obvious, the answer this one is "no idea".)

[Nico, 2012-01-23 18:46:37]

On Mon, Jan 23, 2012 at 10:44 AM,  <evan@chromium.org> wrote:
> On 2012/01/23 18:36:03, Nico wrote:
>>
>> Do we use any tools that look at this NOLINT these days?
>
>
> (In case it wasn't obvious, the answer this one is "no idea".)

(cs.chromium.org tells me that depot_tools/cpp_lint.py probably looks at these.)

[commit-bot: I haz the power, 2012-01-23 18:47:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/9200009/3002

[commit-bot: I haz the power, 2012-01-23 20:29:08]

Change committed as 118725