Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: src/d8-debug.h

Issue 9200006: Fix remote debugger crash. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/d8.cc ('k') | src/d8-debug.cc » ('j') | src/d8-debug.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/d8-debug.h
diff --git a/src/d8-debug.h b/src/d8-debug.h
index aeff3c121c1b71244352d05fdc271327dbcb4283..694fa739fe01a989351b9470cd4d2e600092d40f 100644
--- a/src/d8-debug.h
+++ b/src/d8-debug.h
@@ -43,7 +43,7 @@ void HandleDebugEvent(DebugEvent event,
// Start the remove debugger connecting to a V8 debugger agent on the specified
// port.
-void RunRemoteDebugger(int port);
+void RunRemoteDebugger(int port, Handle<Context> context);
// Forward declerations.
class RemoteDebuggerEvent;
@@ -53,11 +53,13 @@ class ReceiverThread;
// Remote debugging class.
class RemoteDebugger {
public:
- explicit RemoteDebugger(int port)
+ explicit RemoteDebugger(int port, Handle<Context> context)
Jakob Kummerow 2012/01/19 16:23:13 nit: "explicit" is no longer necessary.
: port_(port),
event_access_(i::OS::CreateMutex()),
event_available_(i::OS::CreateSemaphore(0)),
- head_(NULL), tail_(NULL) {}
+ head_(NULL),
+ tail_(NULL),
+ context_(context) {}
void Run();
// Handle events from the subordinate threads.
@@ -89,6 +91,7 @@ class RemoteDebugger {
i::Semaphore* event_available_;
RemoteDebuggerEvent* head_;
RemoteDebuggerEvent* tail_;
+ Handle<Context> context_;
friend class ReceiverThread;
};
« no previous file with comments | « src/d8.cc ('k') | src/d8-debug.cc » ('j') | src/d8-debug.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698