Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9197019: Add ash_shell as an alias for aura_shell. (Closed)

Created:
8 years, 11 months ago by Peter Mayo
Modified:
8 years, 9 months ago
Reviewers:
James Cook, nsylvain
CC:
chromium-reviews, cmp, nsylvain+cc_chromium.org
Visibility:
Public.

Description

Add ash_shell as an alias for aura_shell. The framework section has changed names. BUG=chromium:110107 TEST=None (No effect as yet) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126429

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M scripts/master/factory/chromium_factory.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Peter Mayo
The start of the renaming process for this.
8 years, 11 months ago (2012-01-13 00:26:23 UTC) #1
James Cook
http://codereview.chromium.org/9197019/diff/1/scripts/master/factory/chromium_factory.py File scripts/master/factory/chromium_factory.py (right): http://codereview.chromium.org/9197019/diff/1/scripts/master/factory/chromium_factory.py#newcode291 scripts/master/factory/chromium_factory.py:291: if R('aura_shell') or R('ash_shell'): I think 'ash_shell' should just ...
8 years, 11 months ago (2012-01-13 00:39:12 UTC) #2
Peter Mayo
http://codereview.chromium.org/9197019/diff/1/scripts/master/factory/chromium_factory.py File scripts/master/factory/chromium_factory.py (right): http://codereview.chromium.org/9197019/diff/1/scripts/master/factory/chromium_factory.py#newcode291 scripts/master/factory/chromium_factory.py:291: if R('aura_shell') or R('ash_shell'): On 2012/01/13 00:39:13, James Cook ...
8 years, 11 months ago (2012-01-16 16:48:07 UTC) #3
James Cook
lgtm
8 years, 11 months ago (2012-01-17 17:47:38 UTC) #4
tfarina
On 2012/01/17 17:47:38, James Cook (Chromium) wrote: > lgtm Was this landed already? If not, ...
8 years, 9 months ago (2012-02-28 18:28:04 UTC) #5
Peter Mayo
8 years, 9 months ago (2012-03-01 16:34:20 UTC) #6 
On 2012/02/28 18:28:04, tfarina wrote:
> On 2012/01/17 17:47:38, James Cook (Chromium) wrote:
> > lgtm
> 
> Was this landed already? If not, why?

I haven't because it would be dead/future code until I can dedicate the time to
update at least on config to use it.

Powered by Google App Engine
This is Rietveld 408576698