Adds custom ttl argument to HostCache::Set.

net/base/host_resolver_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/host_resolver_impl.h"
 
 #if defined(OS_WIN)
 #include <Winsock2.h>
 #elif defined(OS_POSIX)
 #include <netdb.h>
@@ skipping 32 matching lines @@
 #endif
 
 namespace net {
 
 namespace {
 
 // Limit the size of hostnames that will be resolved to combat issues in
 // some platform's resolvers.
 const size_t kMaxHostLength = 4096;
 
+// Default TTL for successful resolutions with ProcTask.
+const base::TimeDelta kCacheEntryTTL = base::TimeDelta::FromMinutes(1);

[mmenke, 2012/01/20 22:02:16]

The constants up here should just be the times as integers.

+
 // Helper to mutate the linked list contained by AddressList to the given
 // port. Note that in general this is dangerous since the AddressList's
 // data might be shared (and you should use AddressList::SetPort).
 //
 // However since we allocated the AddressList ourselves we can safely
 // do this optimization and avoid reallocating the list.
 void MutableSetPort(int port, AddressList* addrlist) {
   struct addrinfo* mutable_head =
       const_cast<struct addrinfo*>(addrlist->head());
   SetPortForAllAddrinfos(mutable_head, port);
@@ skipping 1283 matching lines @@
   pool->AdjustNumOutstandingJobs(-1);
 }
 
 void HostResolverImpl::OnJobComplete(Job* job,
                                      int net_error,
                                      int os_error,
                                      const AddressList& addrlist) {
   RemoveOutstandingJob(job);
 
   // Write result to the cache.
-  if (cache_.get())
-    cache_->Set(job->key(), net_error, addrlist, base::TimeTicks::Now());
-
+  if (cache_.get()) {
+    base::TimeDelta ttl = base::TimeDelta::FromSeconds(0);
+    if (net_error == OK)
+      ttl = kCacheEntryTTL;
+    cache_->Set(job->key(), net_error, addrlist,
+                base::TimeTicks::Now(),
+                ttl);
+  }
   OnJobCompleteInternal(job, net_error, os_error, addrlist);
 }
 
 void HostResolverImpl::AbortJob(Job* job) {
   OnJobCompleteInternal(job, ERR_ABORTED, 0 /* no os_error */, AddressList());
 }
 
 void HostResolverImpl::OnJobCompleteInternal(
     Job* job,
     int net_error,
@@ skipping 227 matching lines @@
   // resolv.conf changes so we don't need to do anything to clear that cache.
   if (cache_.get())
     cache_->clear();
   // Existing jobs will have been sent to the original server so they need to
   // be aborted. TODO(Craig): Should these jobs be restarted?
   AbortAllInProgressJobs();
   // |this| may be deleted inside AbortAllInProgressJobs().
 }
 
 }  // namespace net