Adds custom ttl argument to HostCache::Set.

net/base/host_cache.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_HOST_CACHE_H_
 #define NET_BASE_HOST_CACHE_H_
 #pragma once
 
 #include <map>
 #include <string>
@@ skipping 55 matching lines @@
       return hostname < other.hostname;
     }
 
     std::string hostname;
     AddressFamily address_family;
     HostResolverFlags host_resolver_flags;
   };
 
   typedef std::map<Key, scoped_refptr<Entry> > EntryMap;
 
-  // Constructs a HostCache that caches successful host resolves for
-  // |success_entry_ttl| time, and failed host resolves for
-  // |failure_entry_ttl|. The cache will store up to |max_entries|.
-  HostCache(size_t max_entries,
-            base::TimeDelta success_entry_ttl,
-            base::TimeDelta failure_entry_ttl);
+  // Constructs a HostCache that stores up to |max_entries|.
+  HostCache(size_t max_entries);
 
   ~HostCache();
 
   // Returns a pointer to the entry for |key|, which is valid at time
   // |now|. If there is no such entry, returns NULL.
   const Entry* Lookup(const Key& key, base::TimeTicks now) const;
 
   // Overwrites or creates an entry for |key|. Returns the pointer to the
   // entry, or NULL on failure (fails if caching is disabled).
-  // (|error|, |addrlist|) is the value to set, and |now| is the current
-  // timestamp.
+  // (|error|, |addrlist|) is the value to set, |ttl| is the "time to live",
+  // and |now| is the current timestamp.
   Entry* Set(const Key& key,
              int error,
              const AddressList& addrlist,
+             base::TimeDelta ttl,
              base::TimeTicks now);

[mmenke, 2012/01/19 22:12:43]

nit:  Cognitively, I think putting |now| before |ttl| is a little more
intuitive.  Base value before delta.

 
   // Empties the cache
   void clear();
 
   // Returns the number of entries in the cache.
   size_t size() const;
 
   // Following are used by net_internals UI.
   size_t max_entries() const;
 
-  base::TimeDelta success_entry_ttl() const;
-
-  base::TimeDelta failure_entry_ttl() const;
-
   // Note that this map may contain expired entries.
   const EntryMap& entries() const;
 
   // Creates a default cache.
   static HostCache* CreateDefaultCache();
 
  private:
   FRIEND_TEST_ALL_PREFIXES(HostCacheTest, Compact);
   FRIEND_TEST_ALL_PREFIXES(HostCacheTest, NoCache);
 
   // Returns true if this cache entry's result is valid at time |now|.
   static bool CanUseEntry(const Entry* entry, const base::TimeTicks now);
 
   // Prunes entries from the cache to bring it below max entry bound. Entries
   // matching |pinned_entry| will NOT be pruned.
   void Compact(base::TimeTicks now, const Entry* pinned_entry);
 
   // Returns true if this HostCache can contain no entries.
   bool caching_is_disabled() const {
     return max_entries_ == 0;
   }
 
   // Bound on total size of the cache.
   size_t max_entries_;
 
-  // Time to live for cache entries.
-  base::TimeDelta success_entry_ttl_;
-  base::TimeDelta failure_entry_ttl_;
-
   // Map from hostname (presumably in lowercase canonicalized format) to
   // a resolved result entry.
   EntryMap entries_;
 
   DISALLOW_COPY_AND_ASSIGN(HostCache);
 };
 
 }  // namespace net
 
 #endif  // NET_BASE_HOST_CACHE_H_