Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 9195029: Add ppapi perftests infrastructure, plus a performance test for PPP_Messaging. (Closed)

Created:
8 years, 11 months ago by dmichael (off chromium)
Modified:
8 years, 11 months ago
Reviewers:
piman
CC:
chromium-reviews
Visibility:
Public.

Description

Add ppapi perftests infrastructure, plus a performance test for PPP_Messaging. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118888

Patch Set 1 #

Patch Set 2 : tweaks #

Total comments: 3

Patch Set 3 : Address review comments #

Patch Set 4 : Fix unused variable warning #

Patch Set 5 : Remove other unused variable #

Patch Set 6 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -4 lines) Patch
M ppapi/ppapi_tests.gypi View 1 3 chunks +39 lines, -4 lines 0 comments Download
A ppapi/proxy/ppapi_perftests.cc View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
A ppapi/proxy/ppp_messaging_proxy_perftest.cc View 1 2 3 4 1 chunk +82 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
dmichael (off chromium)
I have another CL to cut elide some string copies in the OOP proxy. It's ...
8 years, 11 months ago (2012-01-20 17:29:58 UTC) #1
piman
LGTM overall http://codereview.chromium.org/9195029/diff/5002/ppapi/proxy/ppapi_perftests.cc File ppapi/proxy/ppapi_perftests.cc (right): http://codereview.chromium.org/9195029/diff/5002/ppapi/proxy/ppapi_perftests.cc#newcode1 ppapi/proxy/ppapi_perftests.cc:1: // Copyright (c) 2011 The Chromium Authors. ...
8 years, 11 months ago (2012-01-20 17:39:23 UTC) #2
dmichael (off chromium)
http://codereview.chromium.org/9195029/diff/5002/ppapi/proxy/ppp_messaging_proxy_perftest.cc File ppapi/proxy/ppp_messaging_proxy_perftest.cc (right): http://codereview.chromium.org/9195029/diff/5002/ppapi/proxy/ppp_messaging_proxy_perftest.cc#newcode61 ppapi/proxy/ppp_messaging_proxy_perftest.cc:61: PP_Var host_string = StringVar::StringToPPVar(kTestString); On 2012/01/20 17:39:23, piman wrote: ...
8 years, 11 months ago (2012-01-20 17:53:20 UTC) #3
piman
On 2012/01/20 17:53:20, dmichael wrote: > http://codereview.chromium.org/9195029/diff/5002/ppapi/proxy/ppp_messaging_proxy_perftest.cc > File ppapi/proxy/ppp_messaging_proxy_perftest.cc (right): > > http://codereview.chromium.org/9195029/diff/5002/ppapi/proxy/ppp_messaging_proxy_perftest.cc#newcode61 > ...
8 years, 11 months ago (2012-01-20 18:07:48 UTC) #4
dmichael (off chromium)
Good point. Done.
8 years, 11 months ago (2012-01-20 21:21:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/9195029/13001
8 years, 11 months ago (2012-01-20 21:22:18 UTC) #6
piman
lgtm
8 years, 11 months ago (2012-01-20 21:24:34 UTC) #7
commit-bot: I haz the power
Try job failure for 9195029-13001 (retry) on linux_clang for step "compile" (clobber build). It's a ...
8 years, 11 months ago (2012-01-20 22:16:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/9195029/15001
8 years, 11 months ago (2012-01-24 00:25:36 UTC) #9
commit-bot: I haz the power
Try job failure for 9195029-15001 (retry) on mac_rel for step "compile" (clobber build). It's a ...
8 years, 11 months ago (2012-01-24 01:37:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/9195029/17003
8 years, 11 months ago (2012-01-24 02:07:18 UTC) #11
commit-bot: I haz the power
Try job failure for 9195029-17003 (retry) on mac_rel for step "compile" (clobber build). It's a ...
8 years, 11 months ago (2012-01-24 02:43:41 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/9195029/20004
8 years, 11 months ago (2012-01-24 18:29:27 UTC) #13
commit-bot: I haz the power
8 years, 11 months ago (2012-01-24 20:29:05 UTC) #14
Change committed as 118888

Powered by Google App Engine
This is Rietveld 408576698