Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 9195028: Convert use of int ms to TimeDelta in files owned by bulach. (Closed)

Created:
8 years, 11 months ago by Ted Vessenes
Modified:
8 years, 11 months ago
Reviewers:
bulach
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Convert use of int ms to TimeDelta in files owned by bulach. BUG=108171 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118502

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M content/browser/device_orientation/provider_impl.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/device_orientation/provider_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/geolocation/device_data_provider_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/geolocation/gps_location_provider_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/geolocation/network_location_provider.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/geolocation/wifi_data_provider_common.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Ted Vessenes
I've updated these files and forcibly included base/time.h in provider_impl.h. You mentioned that different build ...
8 years, 11 months ago (2012-01-19 21:17:30 UTC) #1
bulach
lgtm the first set of failures was due my wrong param for "trychange.py": I used ...
8 years, 11 months ago (2012-01-20 16:29:57 UTC) #2
Ted Vessenes
Just to confirm, I have authorization to commit this patch now?
8 years, 11 months ago (2012-01-20 16:47:22 UTC) #3
bulach
On 2012/01/20 16:47:22, tedv wrote: > Just to confirm, I have authorization to commit this ...
8 years, 11 months ago (2012-01-20 16:51:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/9195028/1
8 years, 11 months ago (2012-01-20 16:52:26 UTC) #5
Ted Vessenes
Well I can't do much if it breaks anyway, other than answer questions. But lets ...
8 years, 11 months ago (2012-01-20 16:52:57 UTC) #6
commit-bot: I haz the power
Try job failure for 9195028-1 (retry) on mac_rel for step "update". It's a second try, ...
8 years, 11 months ago (2012-01-20 17:59:00 UTC) #7
Ted Vessenes
Am I correct in asserting this is a spurious failure due to some internal network ...
8 years, 11 months ago (2012-01-20 18:01:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/9195028/1
8 years, 11 months ago (2012-01-20 18:58:13 UTC) #9
commit-bot: I haz the power
8 years, 11 months ago (2012-01-20 21:22:05 UTC) #10
Change committed as 118502

Powered by Google App Engine
This is Rietveld 408576698