Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 9195027: In cases of SSL error page due to HSTS, explain why the user cannot proceed. (Closed)

Created:
8 years, 11 months ago by palmer
Modified:
8 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

In cases of SSL error page due to HSTS, explain why the user cannot proceed. BUG=110191 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118557

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/ssl_error.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ssl/ssl_blocking_page.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
palmer
This is a follow-on to http://codereview.chromium.org/8856010, so nominating some of the same reviewers as before. ...
8 years, 11 months ago (2012-01-19 21:15:02 UTC) #1
Evan Stade
lgtm http://codereview.chromium.org/9195027/diff/3002/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/9195027/diff/3002/chrome/app/generated_resources.grd#newcode7579 chrome/app/generated_resources.grd:7579: You cannot proceed, because the website operator has ...
8 years, 11 months ago (2012-01-20 00:16:57 UTC) #2
palmer
http://codereview.chromium.org/9195027/diff/3002/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/9195027/diff/3002/chrome/app/generated_resources.grd#newcode7579 chrome/app/generated_resources.grd:7579: You cannot proceed, because the website operator has requested ...
8 years, 11 months ago (2012-01-20 00:19:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/palmer@chromium.org/9195027/6002
8 years, 11 months ago (2012-01-20 00:20:04 UTC) #4
commit-bot: I haz the power
Try job failure for 9195027-6002 (retry) (retry) on mac_rel for step "browser_tests". It's a second ...
8 years, 11 months ago (2012-01-20 03:06:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/palmer@chromium.org/9195027/6002
8 years, 11 months ago (2012-01-20 18:20:43 UTC) #6
commit-bot: I haz the power
Try job failure for 9195027-6002 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 11 months ago (2012-01-20 20:29:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/palmer@chromium.org/9195027/6002
8 years, 11 months ago (2012-01-20 22:08:24 UTC) #8
commit-bot: I haz the power
Change committed as 118557
8 years, 11 months ago (2012-01-21 00:09:31 UTC) #9
wtc
8 years, 11 months ago (2012-01-21 01:17:52 UTC) #10
Patch Set 3 LGTM.

Powered by Google App Engine
This is Rietveld 408576698