chrome/browser/extensions/extension_host.cc - Issue 9195018: Disable modal JavaScript dialogs for platform apps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_host.cc

Issue 9195018: Disable modal JavaScript dialogs for platform apps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix spelling Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_host.cc

diff --git a/chrome/browser/extensions/extension_host.cc b/chrome/browser/extensions/extension_host.cc

index a47c8ebeaabff3d4a7a2febf1548843cf5b9f13e..5e5f4fc408a1ea6329f1f50da94d65e0eda0e075 100644

--- a/chrome/browser/extensions/extension_host.cc

+++ b/chrome/browser/extensions/extension_host.cc

@@ -404,6 +404,10 @@ void ExtensionHost::CloseContents(WebContents* contents) {

}

+bool ExtensionHost::ShouldSuppressDialogs() {

+ return extension_->is_platform_app();

WebContents* ExtensionHost::OpenURLFromTab(WebContents* source,

const OpenURLParams& params) {

// Whitelist the dispositions we will allow to be opened.