Move IN_OVERFLOW from Panel::ExpansionState to new enum.

chrome/browser/ui/panels/panel_manager.cc

Index: chrome/browser/ui/panels/panel_manager.cc
diff --git a/chrome/browser/ui/panels/panel_manager.cc b/chrome/browser/ui/panels/panel_manager.cc
index 25ca6e03d0f6a2f888d86b3aca01a03ff8b0d9ba..6361cc911d2175e98b3a27895a604dc5d7ee8890 100644
--- a/chrome/browser/ui/panels/panel_manager.cc
+++ b/chrome/browser/ui/panels/panel_manager.cc
@@ -178,13 +178,20 @@ void PanelManager::EndDragging(bool cancelled) {
   panel_strip_->EndDragging(cancelled);
 }
 
-void PanelManager::OnPanelExpansionStateChanged(Panel* panel) {
-  panel_strip_->OnPanelExpansionStateChanged(panel);
-  panel_overflow_strip_->OnPanelExpansionStateChanged(panel);
+void PanelManager::OnPanelLayoutStateChanged(Panel* panel,
+                                            Panel::LayoutState old_state) {

[prasadt, 2012/01/20 04:43:08]

Indentation off by a space.

[jianli, 2012/01/20 23:33:08]

Done.

+  panel_strip_->OnPanelLayoutStateChanged(panel, old_state);
+  panel_overflow_strip_->OnPanelLayoutStateChanged(panel, old_state);

[prasadt, 2012/01/20 04:43:08]

This may be cleaner if the strips just listened to the notification fired by
Panel.

[jennb, 2012/01/20 23:28:59]

Agree that this needs to be cleaned up. Not in this patch though. The registrar
may be overkill. Maybe part of the layout manager refactor. Can discuss more
f2f.

[jianli, 2012/01/20 23:33:08]

Yes, it might be. But for our usage, I think it would be simpler to notify the
strip directly, instead of incurring overhead with the notification scheme.

+}
+
+void PanelManager::OnPanelExpansionStateChanged(
+    Panel* panel, Panel::ExpansionState old_state) {
+  if (panel->layout_state() == Panel::DOCKED)
+    panel_strip_->OnPanelExpansionStateChanged(panel, old_state);

[prasadt, 2012/01/20 04:43:08]

Same comment as above. PanelStrip could just listen to the notification. The
logic would seem like it belongs in PanelStrip.

[jianli, 2012/01/20 23:33:08]

ExpansonState now solely belongs to PanelStrip. I removed this method since we
now call directly into PanelStrip for any expansion state changes. 

 }
 
 void PanelManager::OnPanelAttentionStateChanged(Panel* panel) {
-  if (panel->expansion_state() == Panel::IN_OVERFLOW)
+  if (panel->layout_state() == Panel::IN_OVERFLOW)
     panel_overflow_strip_->OnPanelAttentionStateChanged(panel);
 }