Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 9194003: Revert 117533 - Fix ASLR Windows build configuration (Closed)

Created:
8 years, 11 months ago by Wez
Modified:
8 years, 11 months ago
Reviewers:
Derek Bruening
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 117533 - Fix ASLR Windows build configuration 1) Actually turn off ASLR for Debug build. Despite the comments, this was not happening in reality because the /dynamicbase linker flag overrode the VCLinkerTool.RandomizedBaseAddress setting. 2) Make the ASLR setting configurable from outside (target usage is for particular Dr. Memory builds). TEST=Built googleurl_unittests and ensured its ALSR setting matched that requested, both for default and for custom via new gyp var BUG=109767 Review URL: http://codereview.chromium.org/9169020 TBR=bruening@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117586

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -47 lines) Patch
M build/common.gypi View 6 chunks +12 lines, -47 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Wez
8 years, 11 months ago (2012-01-13 02:43:28 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698