Fix failure

bin/socket_stream.dart

-// Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
+// Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class SocketInputStream implements InputStream {
   SocketInputStream(Socket socket) : _socket = socket {
     _socket.closeHandler = _closeHandler;
   }
 
   List<int> read([int len]) {
     int bytesToRead = available();
-    if (bytesToRead == 0) return null;
+    if (bytesToRead <= 0) return null;

[Søren Gjesse, 2012/01/12 07:32:47]

I think we should assert that available is never negative and make sure that
available throws an exception if -1 is returned from the system call. We have it
on our OKRs to go through the error handling in the IO subsystem.

[siva, 2012/01/12 19:30:50]

Removed this check here and added an asserion in the native code for available
being always >= 0.
When you do your cleanup you can take care of this.

On 2012/01/12 07:32:47, Søren Gjesse wrote:

     if (len !== null) {
       if (len <= 0) {
         throw new StreamException("Illegal length $len");
       } else if (bytesToRead > len) {
         bytesToRead = len;
       }
     }
     List<int> buffer = new List<int>(bytesToRead);
     int bytesRead = _socket.readList(buffer, 0, bytesToRead);
     if (bytesRead < bytesToRead) {
@@ skipping 157 matching lines @@
     if (_streamErrorHandler != null) _streamErrorHandler();
   }
 
   Socket _socket;
   _BufferList _pendingWrites;
   var _noPendingWriteHandler;
   var _streamErrorHandler;
   bool _closing = false;
   bool _closed = false;
 }