Tweak Win ExtensionPopup::OnNativeFocusChange logic.

Tweak Win ExtensionPopup::OnNativeFocusChange logic.
Close even if focused_before is not the popup window.
Fixes non-aura Windows ExtensionPopup close logic added in crrev.com/113936.

BUG=106723, 106958, 110600
TEST=Open, click on, then click away from an extension popup, expect to close.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118963

[msw, 2012-01-23 21:24:03]

Matt, Ben: Please take a look; thanks!

[Matt Perry, 2012-01-23 21:28:00]

lgtm

[Ben Goodger (Google), 2012-01-23 23:54:48]

LGTM I guess... 

BTW, since javascript dialogs are always the devil (they block all tabs on all
browsers, which means that on ChromeOS they act like UAC prompts do on Windows),
it'd be great if we would take a stand and (for example) just decide not to
support them in new app surfaces that we create, like extensions.

Aaron?

[msw, 2012-01-24 01:44:35]

I pinged Aaron with an e-mail; I'm going to land this now and will help with any
followup work.

[commit-bot: I haz the power, 2012-01-24 01:45:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/9193018/4002

[mihaip_google.com, 2012-01-24 01:53:52]

On Mon, Jan 23, 2012 at 3:54 PM, <ben@chromium.org> wrote:

> BTW, since javascript dialogs are always the devil (they block all tabs on
> all
> browsers, which means that on ChromeOS they act like UAC prompts do on
> Windows),
> it'd be great if we would take a stand and (for example) just decide not to
> support them in new app surfaces that we create, like extensions.
>

FWIW, Apps v2 will not support JS modal dialogs (
http://codereview.chromium.org/9195018/).

Mihai

[commit-bot: I haz the power, 2012-01-24 02:29:54]

Try job failure for 9193018-4002 (retry) on mac_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[msw, 2012-01-24 02:31:03]

On 2012/01/24 02:29:54, I haz the power (commit-bot) wrote:
> Try job failure for 9193018-4002 (retry) on mac_rel for step "compile"
(clobber
> build).
> It's a second try, previously, step "compile" failed.
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Errors in third_party/WebKit/Source/WebCore/css/CSSStyleDeclaration.cpp look
unrelated.

[commit-bot: I haz the power, 2012-01-24 02:31:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/9193018/4002

[commit-bot: I haz the power, 2012-01-24 03:16:54]

Try job failure for 9193018-4002 (retry) on mac_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-01-24 20:38:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/9193018/9007

[Aaron Boodman, 2012-01-24 23:33:59]

I think at this point the ship has sailed for extensions, unless we want to do
it in some future manifest_version=3.

[commit-bot: I haz the power, 2012-01-25 00:55:11]

Change committed as 118963