Issue 9193013: WebSocket Pepper API: SetBinaryType() returned unexpected PP_FALSE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9193013: WebSocket Pepper API: SetBinaryType() returned unexpected PP_FALSE (Closed)

Created:
8 years, 11 months ago by Takashi Toyoshima

Modified:
8 years, 11 months ago

Reviewers:
dmichael (off chromium), brettw, piman

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

WebSocket Pepper API: SetBinaryType() returned unexpected PP_FALSE Usually, the websocket_ doesn't have an object when SetBinaryType() is called. BUG=87310 TEST=ui_tests --gtest_filter='*WebSocket_CcInterfaces' Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118787

Patch Set 1 : for review #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	ppapi/tests/test_websocket.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	webkit/plugins/ppapi/ppb_websocket_impl.cc	View		1 chunk	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Takashi Toyoshima

Hi, this is a tiny review to fix a bug on wrong returning value of ...

8 years, 11 months ago (2012-01-23 14:40:01 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/9193013/2001

8 years, 11 months ago (2012-01-24 01:03:03 UTC) #3

Change committed as 118787

Expand Messages | Collapse Messages