Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8295)

Unified Diff: chrome/renderer/resources/extensions/schema_generated_bindings.js

Issue 9192029: Bindings layer for declarative events API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Store apiDefinitions directly in chromeHidden Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/schema_generated_bindings.js
diff --git a/chrome/renderer/resources/extensions/schema_generated_bindings.js b/chrome/renderer/resources/extensions/schema_generated_bindings.js
index 413476272c462cfa1d4e332edc3ff488334285c4..5192bb5fee2441fc9860b3d0ebd2da6065a1b6bc 100644
--- a/chrome/renderer/resources/extensions/schema_generated_bindings.js
+++ b/chrome/renderer/resources/extensions/schema_generated_bindings.js
@@ -183,6 +183,8 @@ var chrome = chrome || {};
opt_args.forIOThread);
}
+ chromeHidden.sendRequest = sendRequest;
+
// TODO(kalman): It's a shame to need to define this function here, since it's
// only used in 2 APIs (browserAction and pageAction). It would be nice to
// only load this if one of those APIs has been loaded.
@@ -355,6 +357,7 @@ var chrome = chrome || {};
chromeHidden.onLoad.addListener(function(extensionId, isExtensionProcess,
isIncognitoProcess) {
var apiDefinitions = GetExtensionAPIDefinition();
+ chromeHidden.apiDefinitions = apiDefinitions;
// Read api definitions and setup api functions in the chrome namespace.
// TODO(rafaelw): Consider defining a json schema for an api definition
@@ -459,10 +462,11 @@ var chrome = chrome || {};
var customEvent = customEvents[apiDef.namespace];
if (customEvent) {
module[eventDef.name] = new customEvent(
- eventName, eventDef.parameters, eventDef.extraParameters);
+ eventName, eventDef.parameters, eventDef.extraParameters,
+ eventDef.options);
} else {
module[eventDef.name] = new chrome.Event(
- eventName, eventDef.parameters);
+ eventName, eventDef.parameters, eventDef.options);
}
});
}

Powered by Google App Engine
This is Rietveld 408576698