Bindings layer for declarative events API

chrome/browser/extensions/api/declarative/declarative_api.cc

Index: chrome/browser/extensions/api/declarative/declarative_api.cc
diff --git a/chrome/browser/extensions/api/declarative/declarative_api.cc b/chrome/browser/extensions/api/declarative/declarative_api.cc
new file mode 100644
index 0000000000000000000000000000000000000000..ca5fd83edad85faed77c6683dbe86fb7dd9f2d59
--- /dev/null
+++ b/chrome/browser/extensions/api/declarative/declarative_api.cc
@@ -0,0 +1,31 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/api/declarative/declarative_api.h"
+
+#include "base/values.h"
+
+namespace extensions {
+
+bool AddRulesFunction::RunImpl() {
+  // LOG(ERROR) << "AddRulesFunction called";
+
+  // We always return an empty list here. The binding of return values
+  // is handled in JavaScript by event.js.
+  result_.reset(new ListValue());

[Aaron Boodman, 2012/01/31 00:11:17]

Nit: No need to return anything in that case then? (go easy on the IPC system
:-)).

[battre, 2012/01/31 12:28:50]

If we don't return an empty list here, we get the following DCHECK:


[7123:7123:617285019860:FATAL:schema_generated_bindings.cc(392)] Check failed:
false. Callback validation error during experimental.declarative.addRules --
Error: Parameter 1 is required.
    at Object.validate (extensions/schema_generated_bindings.js:65:15)
    at Object.<anonymous> (extensions/schema_generated_bindings.js:110:26)
Backtrace:
        base::debug::StackTrace::StackTrace() [0x7ffc0c1cc63a]
        logging::LogMessage::~LogMessage() [0x7ffc0c1fb3a4]
        extensions::SchemaGeneratedBindings::HandleResponse() [0x7ffc10da1a8a]
        ExtensionHelper::OnExtensionResponse() [0x7ffc10d94ea1]
        DispatchToMethod<>() [0x7ffc10d96ec8]
        ExtensionMsg_Response::Dispatch<>() [0x7ffc10d962e1]
        ExtensionHelper::OnMessageReceived() [0x7ffc10d946b0]
        RenderViewImpl::OnMessageReceived() [0x7ffc0ef503a1]
        MessageRouter::RouteMessage() [0x7ffc0ee2037c]
        MessageRouter::OnMessageReceived() [0x7ffc0ee2031e]
        ChildThread::OnMessageReceived() [0x7ffc0ed0de71]
        IPC::ChannelProxy::Context::OnDispatchMessage() [0x7ffc0cfce7c4]
        base::internal::RunnableAdapter<>::Run() [0x7ffc0cfd1cef]
        base::internal::InvokeHelper<>::MakeItSo() [0x7ffc0cfd18b5]
        base::internal::Invoker<>::Run() [0x7ffc0cfd125b]
        base::Callback<>::Run() [0x7ffc0c1c491f]
        MessageLoop::RunTask() [0x7ffc0c200ef8]
        MessageLoop::DeferOrRunPendingTask() [0x7ffc0c20100f]
        MessageLoop::DoWork() [0x7ffc0c201831]
        base::MessagePumpDefault::Run() [0x7ffc0c209c20]
        MessageLoop::RunInternal() [0x7ffc0c200bb3]
        MessageLoop::RunHandler() [0x7ffc0c200a66]
        MessageLoop::Run() [0x7ffc0c20039b]
        RendererMain() [0x7ffc0ef933b9]
        (anonymous namespace)::RunZygote() [0x7ffc0e9eb728]
        (anonymous namespace)::RunNamedProcessTypeMain() [0x7ffc0e9eb8fd]
        content::ContentMain() [0x7ffc0e9ebe92]
        ChromeMain [0x7ffc10cb9e1d]
        main [0x7ffc10cb9ddc]
        0x7ffc00609c4d
        0x7ffc10cb9ce9

We may actually change this in the light of Matt's new event pages. I suppose we
don't want to store any state in the events on the JavaScript side if we allow
killing the renderer.

[Aaron Boodman, 2012/02/01 00:27:25]

Ah. OK.
The extension will still be allowed to get the result of these calls. It might
do something like store it, before its event page gets killed.

+  return true;
+}
+
+bool RemoveRulesFunction::RunImpl() {
+  // LOG(ERROR) << "RemoveRulesFunction called";
+  return true;
+}
+
+bool GetRulesFunction::RunImpl() {
+  // LOG(ERROR) << "GetRulesFunction called";
+  result_.reset(new ListValue());
+  return true;
+}
+
+}  // namespace extensions