Issue 9192021: Disallow WebSQL and localStorage in platform apps.

Issue 9192021: Disallow WebSQL and localStorage in platform apps. (Closed)

Created:
8 years, 11 months ago by jstritar

Modified:
8 years, 11 months ago

Reviewers:
tony, Mihai Parparita -not on Chrome

CC:
chromium-reviews, Aaron Boodman, darin-cc_chromium.org, mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Disallow WebSQL and localStorage in platform apps. BUG=none TEST=PlatformAppBrowserTest.DisallowStorage Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119088

Patch Set 2 : block localStorage #

Total comments: 1

Patch Set 4 : . #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -7 lines)			Patch
M	chrome/browser/extensions/extension_webkit_preferences.cc	View	1	2 chunks	+12 lines, -5 lines	0 comments	Download
M	chrome/browser/extensions/platform_app_browsertest.cc	View	1 2 3	1 chunk	+11 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/platform_apps/storage/main.html	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/platform_apps/storage/main.js	View	1 2	1 chunk	+20 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/platform_apps/storage/manifest.json	View	1 2	1 chunk	+12 lines, -0 lines	0 comments	Download
M	webkit/glue/webpreferences.cc	View	1 2 3	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Mihai Parparita -not on Chrome

http://codereview.chromium.org/9192021/diff/5001/chrome/test/data/extensions/platform_apps/storage/main.html File chrome/test/data/extensions/platform_apps/storage/main.html (right): http://codereview.chromium.org/9192021/diff/5001/chrome/test/data/extensions/platform_apps/storage/main.html#newcode12 chrome/test/data/extensions/platform_apps/storage/main.html:12: platform apps require a launch container. Can you move ...

8 years, 11 months ago (2012-01-20 19:59:28 UTC) #2

Mihai Parparita -not on Chrome

Meant to LGTM, since the comment about moving the test code is not blocking.

8 years, 11 months ago (2012-01-21 00:00:20 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jstritar@chromium.org/9192021/18001

8 years, 11 months ago (2012-01-25 16:01:50 UTC) #6

Change committed as 119088

Expand Messages | Collapse Messages