Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1156)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9192009: WebSocket Pepper API: make the API out of dev (Closed)

Created:
8 years, 11 months ago by Takashi Toyoshima
Modified:
8 years, 11 months ago
CC:
darin (slow to review), chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, ihf+watch_chromium.org
Visibility:
Public.

Description

WebSocket Pepper API: make the API out of dev BUG=87310 TEST=ui_test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119425

Patch Set 1 : file renaming and auto generation only #

Patch Set 2 : remove dev #

Patch Set 3 : update copyright year #

Patch Set 4 : just rebase #

Patch Set 5 : remove binary type handling interfaces #

Total comments: 1

Patch Set 6 : rebase (test) #

Total comments: 1

Patch Set 7 : for land #

Unified diffs Side-by-side diffs Delta from patch set Stats (+286 lines, -941 lines) Patch
D ppapi/api/dev/ppb_websocket_dev.idl View 1 2 3 4 5 1 chunk +0 lines, -301 lines 0 comments Download
A + ppapi/api/ppb_websocket.idl View 1 2 3 4 5 6 chunks +16 lines, -16 lines 0 comments Download
D ppapi/c/dev/ppb_websocket_dev.h View 1 2 3 4 5 1 chunk +0 lines, -317 lines 0 comments Download
A + ppapi/c/ppb_websocket.h View 1 2 3 4 5 9 chunks +23 lines, -23 lines 0 comments Download
D ppapi/cpp/dev/websocket_dev.h View 1 2 3 4 5 1 chunk +0 lines, -185 lines 0 comments Download
A + ppapi/cpp/websocket.h View 1 2 3 4 5 5 chunks +15 lines, -15 lines 0 comments Download
A ppapi/cpp/websocket.cc View 1 2 3 4 1 chunk +148 lines, -0 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/browser_globals.h View 1 2 3 4 5 3 chunks +2 lines, -2 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/browser_globals.cc View 1 2 3 4 5 1 chunk +4 lines, -4 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_websocket_rpc_server.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/plugin_globals.h View 1 2 3 4 5 3 chunks +2 lines, -2 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/plugin_globals.cc View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_websocket.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_websocket.cc View 1 2 3 4 5 4 chunks +6 lines, -6 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/ppb_websocket.srpc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/ppapi_sources.gypi View 1 2 3 4 5 4 chunks +3 lines, -3 lines 0 comments Download
M ppapi/tests/all_c_includes.h View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M ppapi/tests/all_cpp_includes.h View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M ppapi/tests/test_websocket.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/tests/test_websocket.cc View 1 2 3 4 5 7 chunks +11 lines, -11 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_public_dev.h View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/thunk/ppb_websocket_api.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/thunk/ppb_websocket_thunk.cc View 1 2 3 4 5 3 chunks +5 lines, -5 lines 0 comments Download
M ppapi/thunk/resource_creation_api.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_websocket_impl.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppb_websocket_impl.cc View 1 2 3 4 5 6 17 chunks +31 lines, -31 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Takashi Toyoshima
Thank you for great reviews. I'm not sure if it's a time to make it ...
8 years, 11 months ago (2012-01-19 11:55:59 UTC) #1
dmichael (off chromium)
LGTM from a technical standpoint. Please hold off checking in until there's a little more ...
8 years, 11 months ago (2012-01-24 18:26:01 UTC) #2
Takashi Toyoshima
Thanks, David! I upload another candidate which doesn't have binary type handling interfaces as Patch ...
8 years, 11 months ago (2012-01-26 06:20:23 UTC) #3
dmichael (off chromium)
LGTM +darin for FYI, in case you want to put the brakes on.
8 years, 11 months ago (2012-01-26 22:38:45 UTC) #4
darin (slow to review)
https://chromiumcodereview.appspot.com/9192009/diff/12002/ppapi/api/ppb_websocket.idl File ppapi/api/ppb_websocket.idl (right): https://chromiumcodereview.appspot.com/9192009/diff/12002/ppapi/api/ppb_websocket.idl#newcode10 ppapi/api/ppb_websocket.idl:10: M18 = 1.0 Generally speaking, I'd recommend breaking this ...
8 years, 11 months ago (2012-01-26 23:19:00 UTC) #5
Takashi Toyoshima
Thank you for review. OK, I also think I must break this CL into two ...
8 years, 11 months ago (2012-01-27 01:24:35 UTC) #6
Takashi Toyoshima
I'll push this change to CQ. https://chromiumcodereview.appspot.com/9192009/diff/21001/webkit/plugins/ppapi/ppb_websocket_impl.cc File webkit/plugins/ppapi/ppb_websocket_impl.cc (right): https://chromiumcodereview.appspot.com/9192009/diff/21001/webkit/plugins/ppapi/ppb_websocket_impl.cc#newcode17 webkit/plugins/ppapi/ppb_websocket_impl.cc:17: #include "ppapi/c/ppb_var_array_buffer.h" break ...
8 years, 11 months ago (2012-01-27 06:58:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/9192009/20028
8 years, 11 months ago (2012-01-27 06:58:25 UTC) #8
commit-bot: I haz the power
8 years, 11 months ago (2012-01-27 09:42:43 UTC) #9 
Change committed as 119425

Powered by Google App Engine
This is Rietveld 408576698