Hook up ContentViewCore.add/removeJavascriptInterface()

content/public/browser/android/content_view_core.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_ANDROID_CONTENT_VIEW_CORE_H_
 #define CONTENT_PUBLIC_BROWSER_ANDROID_CONTENT_VIEW_CORE_H_
 
 #include <jni.h>
 
 class GURL;
@@ skipping 19 matching lines @@
 class ContentViewCore {
  public:
   virtual void Destroy(JNIEnv* env, jobject obj) = 0;
 
   static ContentViewCore* Create(JNIEnv* env, jobject obj,
                                  WebContents* web_contents);
   static ContentViewCore* GetNativeContentViewCore(JNIEnv* env, jobject obj);
 
   // --------------------------------------------------------------------------
   // Public methods that call to Java via JNI
   // --------------------------------------------------------------------------

[joth, 2012/07/27 16:59:30]

does anyone know why these are declared as public virtual methods in the base
class? It seems the way Java calls to native should be an internal detail, and
they could be private non-virtual in the concrete class.

[Ted C, 2012/07/27 17:11:47]

I think when were originally defining the content_view_core.h downstream, we
copied all the methods over without filtering.  In many cases they shouldn't be
in the public API (many of the java methods are examples of that), so we can
probably just remove these.

[Steve Block, 2012/07/30 11:45:14]

Done.

 
   virtual void StartContentIntent(const GURL& content_url) = 0;
 
+  virtual void AddJavascriptInterface(
+      JNIEnv* env,
+      jobject obj,
+      jobject object,
+      jstring name,
+      jboolean allow_inherited_methods) = 0;
+  virtual void RemoveJavascriptInterface(JNIEnv* env, jobject obj,
+                                         jstring name) = 0;
  protected:
   virtual ~ContentViewCore() {};
 };
 
 };  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_CONTENT_VIEW_CORE_H_