Issue 9192001: Fix compile on linux_views.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9192001: Fix compile on linux_views. (Closed)

Created:
8 years, 11 months ago by sky

Modified:
8 years, 11 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix compile on linux_views. BUG=109665 TEST=none R=ben@chromium.org TBR=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117312

Patch Set 1 #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	ui/views/examples/table_example.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

8 years, 11 months ago (2012-01-11 22:51:03 UTC) #2

LGTM

On Wed, Jan 11, 2012 at 2:50 PM, <sky@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> Fix compile on linux_views.
>
> BUG=109665
> TEST=none
> R=ben@chromium.org
>
>
> Please review this at
http://codereview.chromium.**org/9192001/<http://codereview.chromium.org/9192...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M ui/views/examples/table_**example.cc
>
>
> Index: ui/views/examples/table_**example.cc
> diff --git a/ui/views/examples/table_**example.cc
> b/ui/views/examples/table_**example.cc
> index 2a8f69540f3f9348b8dc9341719404**6da8acfe07..**
> ab0dbb81efe8432e31e49d8a5aeb82**a217c5dc1c 100644
> --- a/ui/views/examples/table_**example.cc
> +++ b/ui/views/examples/table_**example.cc
> @@ -144,7 +144,7 @@ void TableExample::ButtonPressed(**Button* sender,
> const Event& event) {
>     index = 3;
>     show = column4_visible_checkbox_->**checked();
>   }
> -#if !defined(USE_AURA)
> +#if defined(OS_WIN) && !defined(USE_AURA)
>   table_->SetColumnVisibility(**index, show);
>  #endif
>  }
>
>
>

Expand Messages | Collapse Messages