Handle escapes in string literals.

frog/leg/ssa/codegen.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class SsaCodeGeneratorTask extends CompilerTask {
   SsaCodeGeneratorTask(Compiler compiler) : super(compiler);
   String get name() => 'SSA code generator';
 
   String generate(WorkItem work, HGraph graph) {
     return measure(() {
@@ skipping 15 matching lines @@
   void preGenerateMethod(HGraph graph) {
     if (GENERATE_SSA_TRACE) {
       new HTracer.singleton().traceGraph("codegen", graph);
     }
     new SsaInstructionMerger().visitGraph(graph);
     // Replace the results of check instructions with the
     // original value, if the result is used. This is safe now,
     // since we don't do code motion after this point.
     new SsaCheckInstructionUnuser().visitGraph(graph);
     new SsaConditionMerger().visitGraph(graph);
+      // JavaScript only supports characters in the BMP.
     new SsaPhiEliminator().visitGraph(graph);
     if (GENERATE_SSA_TRACE) {
       new HTracer.singleton().traceGraph("no-phi", graph);
     }
   }
 
   String generateMethod(Map<Element, String> parameterNames,
                         WorkItem work,
                         HGraph graph) {
     preGenerateMethod(graph);
@@ skipping 407 matching lines @@
     buffer.add('new $jsClassReference(');
     // We can't use 'visitArguments', since our arguments start at input[0].
     List<HInstruction> inputs = node.inputs;
     for (int i = 0; i < inputs.length; i++) {
       if (i != 0) buffer.add(', ');
       use(inputs[i]);
     }
     buffer.add(')');
   }
 
-  static String makeStringLiteral(SourceString literal) {
-    // TODO(lrn): Escape string content.
-    return literal.toString();
-  }
-
   visitLiteral(HLiteral node) {
     if (node.isLiteralNull()) {
       buffer.add("(void 0)");
     } else if (node.value is num && node.value < 0) {
       buffer.add('(${node.value})');
     } else if (node.isLiteralString()) {
       QuotedString string = node.value;
-      string.printOn(buffer);
+      String quote = string.quoteChar;
+      buffer.add(quote);
+      string.writeEscaped(buffer, string.quoteCharCode,
+                          (String reason) {
+                               compiler.cancel(reason, instruction: node);
+                          });
+      buffer.add(quote);
     } else {
       buffer.add(node.value);
     }
   }
 
   visitLoopBranch(HLoopBranch node) {
     HBasicBlock branchBlock = currentBlock;
     buffer.add('if (!(');
     use(node.inputs[0]);
     buffer.add(')) break;\n');
@@ skipping 277 matching lines @@
     : super(compiler, work, buffer, parameters, parameterNames);
 
   void visitTypeGuard(HTypeGuard guard) {
     compiler.internalError('Type guard in an unoptimized method');
   }
 
   visitBailoutTarget(HBailoutTarget node) {
     buffer.add('// Bailout target ${node.state}');
   }
 }