Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file | 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file |
| 2 // for details. All rights reserved. Use of this source code is governed by a | 2 // for details. All rights reserved. Use of this source code is governed by a |
| 3 // BSD-style license that can be found in the LICENSE file. | 3 // BSD-style license that can be found in the LICENSE file. |
| 4 | 4 |
| 5 #import("compiler_helper.dart"); | 5 #import("compiler_helper.dart"); |
| 6 | 6 |
| 7 final String TEST_ONE = @""" | 7 final String TEST_ONE = @""" |
| 8 foo(String a) { | 8 foo(String a) { |
| 9 return a.length; | 9 return a.length; |
| 10 } | 10 } |
| 11 """; | 11 """; |
| 12 | 12 |
| 13 final String TEST_TWO = @""" | 13 final String TEST_TWO = @""" |
| 14 foo() { | 14 foo() { |
| 15 return "foo".length; | 15 return "foo".length; |
| 16 } | 16 } |
| 17 """; | 17 """; |
| 18 | 18 |
| 19 final String TEST_THREE = @""" | 19 final String TEST_THREE = @""" |
| 20 foo() { | 20 foo() { |
| 21 return @"foo".length; | 21 return @"foo".length; |
| 22 } | 22 } |
| 23 """; | 23 """; |
| 24 | 24 |
| 25 main() { | 25 main() { |
| 26 String generated = compile(TEST_ONE, 'foo'); | 26 String generated = compile(TEST_ONE, 'foo'); |
| 27 Expect.isTrue(generated.contains("return a.length;")); | 27 Expect.isTrue(generated.contains("return a.length;")); |
| 28 | 28 |
| 29 generated = compile(TEST_TWO, 'foo'); | 29 // TODO(lrn): Reenable when we start constant folding string length properly. |
| 30 Expect.isTrue(generated.contains("return 3;")); | 30 bool failed = false; |
| 31 try { | |
| 32 generated = compile(TEST_TWO, 'foo'); | |
| 33 Expect.isTrue(generated.contains("return 3;")); | |
| 31 | 34 |
| 32 // TODO(ngeoffray): Enable once we support raw strings. | |
| 33 Exception exception; | |
| 34 try { | |
| 35 generated = compile(TEST_THREE, 'foo'); | 35 generated = compile(TEST_THREE, 'foo'); |
| 36 Expect.isTrue(generated.contains("return 3;")); | 36 Expect.isTrue(generated.contains("return 3;")); |
| 37 } catch (var e) { | 37 } catch (Exception e) { |
|
floitsch
2012/01/12 12:30:28
why this change?
Lasse Reichstein Nielsen
2012/01/16 13:30:23
No good reason. I removed the wrapper because I th
| |
| 38 exception = e; | 38 failed = true; |
| 39 } | 39 } |
| 40 Expect.isTrue(exception != null); | 40 Expect.isTrue(failed); |
| 41 } | 41 } |
| OLD | NEW |