Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Unified Diff: net/base/net_log_event_type_list.h

Issue 9190031: DnsClient refactoring + features (timeout, suffix search, server rotation). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added comments. Fixed tests. Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/dns/async_host_resolver.h » ('j') | net/dns/async_host_resolver.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/net_log_event_type_list.h
diff --git a/net/base/net_log_event_type_list.h b/net/base/net_log_event_type_list.h
index 2c273363ce12ee968b9d835789a1e9d27039eb22..3678f847dc02099cb82cfa0c226e5307d6b19463 100644
--- a/net/base/net_log_event_type_list.h
+++ b/net/base/net_log_event_type_list.h
@@ -1205,7 +1205,6 @@ EVENT_TYPE(THROTTLING_GOT_CUSTOM_RETRY_AFTER)
// The BEGIN phase contains the following parameters:
//
// {
-// "dns_server": <IP of the DNS server to which queries are sent>,
// "hostname": <The hostname it is trying to resolve>,
// "query_type": <Type of the query>,
// "source_dependency": <Source id, if any, of what created the
@@ -1215,23 +1214,45 @@ EVENT_TYPE(THROTTLING_GOT_CUSTOM_RETRY_AFTER)
// The END phase contains the following parameters:
//
// {
-// "ip_address_list": <The result of the resolution process,
-// an IPAddressList>
// "net_error": <The net error code for the failure, if any>,
// }
EVENT_TYPE(DNS_TRANSACTION)
+// The start/end of a DnsTransaction query for a fully-qualified domain name.
+//
+// The BEGIN phase contains the following parameters:
+//
+// {
+// "qname": <The fully-qualified domain name it is trying to resolve>,
+// }
+//
+// The END phase contains the following parameters:
+//
+// {
+// "net_error": <The net error code for the failure, if any>,
+// }
+EVENT_TYPE(DNS_TRANSACTION_QUERY)
+
// This event is created when DnsTransaction creates a new UDP socket and
-// tries to resolve the hostname.
+// tries to resolve the fully-qualified name.
//
// It has a single parameter:
//
// {
-// "attempt_number": <current attempt number at resolving hostname>
-// "source_dependency": <Source id of the UDP socket that caused the
-// attempt>,
+// "socket": <Source id of the UDP socket created for the attempt>,
mmenke 2012/01/13 16:44:37 nit: Think "socket_source" is a little clearer.
+// }
+EVENT_TYPE(DNS_TRANSACTION_ATTEMPT)
+
+// This event is created when DnsTransaction receives a matching response.
+//
+// It has the following parameters:
+//
+// {
+// "rcode": <rcode in the received response>,
+// "answer_count": <answer_count in the received response>,
+// "socket": <Source id of the UDP socket that received the response>,
mmenke 2012/01/13 16:44:37 nit: Think "socket_source" is a little clearer.
// }
-EVENT_TYPE(DNS_TRANSACTION_ATTEMPT_STARTED)
+EVENT_TYPE(DNS_TRANSACTION_RESPONSE)
// ------------------------------------------------------------------------
// AsyncHostResolver
« no previous file with comments | « no previous file | net/dns/async_host_resolver.h » ('j') | net/dns/async_host_resolver.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698