DnsClient refactoring + features (timeout, suffix search, server rotation).

net/dns/dns_config_service.h

-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_DNS_DNS_CONFIG_SERVICE_H_
 #define NET_DNS_DNS_CONFIG_SERVICE_H_
 #pragma once
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 20 matching lines @@
   bool EqualsIgnoreHosts(const DnsConfig& d) const;
 
   bool IsValid() const {
     return !nameservers.empty();
   }
 
   // List of name server addresses.
   std::vector<IPEndPoint> nameservers;
   // Suffix search list; used on first lookup when number of dots in given name
   // is less than |ndots|.
+  // TODO(szym): Filter out duplicate entries from this list.
   std::vector<std::string> search;
 
   DnsHosts hosts;
 
   // Resolver options; see man resolv.conf.
-  // TODO(szym): use |ndots| and |search| to determine the sequence of FQDNs
-  // to query given a specific name.
   // TODO(szym): implement DNS Devolution for windows
 
   // Minimum number of dots before global resolution precedes |search|.
   int ndots;
   // Time between retransmissions, see res_state.retrans.
   base::TimeDelta timeout;
-  // Maximum number of retries, see res_state.retry.
+  // Maximum number of attempts, see res_state.retry.
   int attempts;
   // Round robin entries in |nameservers| for subsequent requests.
   bool rotate;
   // Enable EDNS0 extensions.
   bool edns0;
 };
 
 
 // Service for watching when the system DNS settings have changed.
 // Depending on the platform, watches files in /etc/ or win registry.
@@ skipping 63 matching lines @@
   // Written in DoRead, read in OnReadFinished, no locking necessary.
   DnsHosts dns_hosts_;
   bool success_;
 
   DISALLOW_COPY_AND_ASSIGN(DnsHostsReader);
 };
 
 }  // namespace net
 
 #endif  // NET_DNS_DNS_CONFIG_SERVICE_H_