DnsClient refactoring + features (timeout, suffix search, server rotation).

net/dns/async_host_resolver.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_DNS_ASYNC_HOST_RESOLVER_H_
 #define NET_DNS_ASYNC_HOST_RESOLVER_H_
 #pragma once
 
 #include <list>
 #include <map>
@@ skipping 10 matching lines @@
 
 namespace net {
 
 class NET_EXPORT AsyncHostResolver
     : public HostResolver,
       NON_EXPORTED_BASE(public base::NonThreadSafe) {
  public:
   AsyncHostResolver(size_t max_dns_requests,
                     size_t max_pending_requests,
                     HostCache* cache,
-                    DnsClient* client,
+                    scoped_ptr<DnsClient> client,
                     NetLog* net_log);
   virtual ~AsyncHostResolver();
 
   // HostResolver interface
   virtual int Resolve(const RequestInfo& info,
                       AddressList* addresses,
                       const CompletionCallback& callback,
                       RequestHandle* out_req,
                       const BoundNetLog& source_net_log) OVERRIDE;
   virtual int ResolveFromCache(const RequestInfo& info,
                                AddressList* addresses,
                                const BoundNetLog& source_net_log) OVERRIDE;
   virtual void CancelRequest(RequestHandle req_handle) OVERRIDE;
   virtual void SetDefaultAddressFamily(AddressFamily address_family) OVERRIDE;
   virtual AddressFamily GetDefaultAddressFamily() const OVERRIDE;
   virtual HostCache* GetHostCache() OVERRIDE;
 
-  void OnDnsRequestComplete(DnsClient::Request* request,
-                            int result,
-                            const DnsResponse* transaction);
+  void OnDnsTransactionComplete(DnsTransaction* transaction,
+                                int result,
+                                const DnsResponse* response);
 
  private:
   FRIEND_TEST_ALL_PREFIXES(AsyncHostResolverTest, QueuedLookup);
   FRIEND_TEST_ALL_PREFIXES(AsyncHostResolverTest, CancelPendingLookup);
   FRIEND_TEST_ALL_PREFIXES(AsyncHostResolverTest,
                            ResolverDestructionCancelsLookups);
   FRIEND_TEST_ALL_PREFIXES(AsyncHostResolverTest,
                            OverflowQueueWithLowPriorityLookup);
   FRIEND_TEST_ALL_PREFIXES(AsyncHostResolverTest,
                            OverflowQueueWithHighPriorityLookup);
 
   class Request;
 
   typedef std::pair<std::string, uint16> Key;
   typedef std::list<Request*> RequestList;
-  typedef std::list<const DnsClient::Request*> DnsRequestList;
+  typedef std::list<const DnsTransaction*> DnsRequestList;

[cbentzel, 2012/01/13 13:39:54]

DnsTransactionList?

[mmenke, 2012/01/13 16:44:37]

nit:  DnsTransactionList

   typedef std::map<Key, RequestList> KeyRequestListMap;
 
   // Create a new request for the incoming Resolve() call.
   Request* CreateNewRequest(const RequestInfo& info,
                             const CompletionCallback& callback,
                             AddressList* addresses,
                             const BoundNetLog& source_net_log);
 
   // Called when a request has just been started.
   void OnStart(Request* request);
@@ skipping 41 matching lines @@
 
   // Maximum number of pending requests.
   size_t max_pending_requests_;
 
   // Queues based on priority for putting pending requests.
   RequestList pending_requests_[NUM_PRIORITIES];
 
   // Cache of host resolution results.
   scoped_ptr<HostCache> cache_;
 
-  DnsClient* client_;
+  scoped_ptr<DnsClient> client_;
 
   NetLog* net_log_;
 
   DISALLOW_COPY_AND_ASSIGN(AsyncHostResolver);
 };
 
 }  // namespace net
 
 #endif  // NET_DNS_ASYNC_HOST_RESOLVER_H_