DnsClient refactoring + features (timeout, suffix search, server rotation).

net/dns/dns_response_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/dns/dns_response.h"
 
 #include "net/base/io_buffer.h"
 #include "net/dns/dns_protocol.h"
 #include "net/dns/dns_query.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace net {
 
 namespace {
 
 TEST(DnsRecordParserTest, Constructor) {
   const char data[] = { 0 };
 
-  EXPECT_FALSE(DnsRecordParser().IsValid());
-  EXPECT_TRUE(DnsRecordParser(data, 1, 0).IsValid());
-  EXPECT_TRUE(DnsRecordParser(data, 1, 1).IsValid());
+  EXPECT_FALSE(DnsRecordParser().is_valid());
+  EXPECT_TRUE(DnsRecordParser(data, 1, 0).is_valid());
+  EXPECT_TRUE(DnsRecordParser(data, 1, 1).is_valid());
 
   EXPECT_FALSE(DnsRecordParser(data, 1, 0).AtEnd());
   EXPECT_TRUE(DnsRecordParser(data, 1, 1).AtEnd());
 }
 
 TEST(DnsRecordParserTest, ParseName) {
   const uint8 data[] = {
       // all labels "foo.example.com"
       0x03, 'f', 'o', 'o',
       0x07, 'e', 'x', 'a', 'm', 'p', 'l', 'e',
       0x03, 'c', 'o', 'm',
       // byte 0x10
       0x00,
       // byte 0x11
       // part label, part pointer, "bar.example.com"
       0x03, 'b', 'a', 'r',
       0xc0, 0x04,
       // byte 0x17
       // all pointer to "bar.example.com", 2 jumps
       0xc0, 0x11,
       // byte 0x1a
   };
 
   std::string out;
   DnsRecordParser parser(data, sizeof(data), 0);
-  ASSERT_TRUE(parser.IsValid());
+  ASSERT_TRUE(parser.is_valid());
 
   EXPECT_EQ(0x11, parser.ParseName(data + 0x00, &out));
   EXPECT_EQ("foo.example.com", out);
   // Check that the last "." is never stored.
   out.clear();
   EXPECT_EQ(0x1, parser.ParseName(data + 0x10, &out));
   EXPECT_EQ("", out);
   out.clear();
   EXPECT_EQ(0x6, parser.ParseName(data + 0x11, &out));
   EXPECT_EQ("bar.example.com", out);
@@ skipping 22 matching lines @@
       // pointer loop
       0xc0, 0x08,
       0xc0, 0x06,
       // incorrect label type (currently supports only direct and pointer)
       0x80, 0x00,
       // truncated name (missing root label)
       0x02, 'x', 'x',
   };
 
   DnsRecordParser parser(data, sizeof(data), 0);
-  ASSERT_TRUE(parser.IsValid());
+  ASSERT_TRUE(parser.is_valid());
 
   std::string out;
   EXPECT_EQ(0, parser.ParseName(data + 0x00, &out));
   EXPECT_EQ(0, parser.ParseName(data + 0x04, &out));
   EXPECT_EQ(0, parser.ParseName(data + 0x08, &out));
   EXPECT_EQ(0, parser.ParseName(data + 0x0a, &out));
   EXPECT_EQ(0, parser.ParseName(data + 0x0c, &out));
   EXPECT_EQ(0, parser.ParseName(data + 0x0e, &out));
 }
 
@@ skipping 97 matching lines @@
     0x00, 0x04,         // RDLENGTH is 4 bytes.
     0x4a, 0x7d,         // RDATA is the IP: 74.125.95.121
     0x5f, 0x79,
   };
 
   DnsResponse resp;
   memcpy(resp.io_buffer()->data(), response_data, sizeof(response_data));
 
   // Reject too short.
   EXPECT_FALSE(resp.InitParse(query->io_buffer()->size() - 1, *query));
+  EXPECT_FALSE(resp.is_valid());
 
   // Reject wrong id.
   scoped_ptr<DnsQuery> other_query(query->CloneWithNewId(0xbeef));
   EXPECT_FALSE(resp.InitParse(sizeof(response_data), *other_query));
+  EXPECT_FALSE(resp.is_valid());
 
   // Reject wrong question.
   scoped_ptr<DnsQuery> wrong_query(
       new DnsQuery(0xcafe, qname, dns_protocol::kTypeCNAME));
   EXPECT_FALSE(resp.InitParse(sizeof(response_data), *wrong_query));
+  EXPECT_FALSE(resp.is_valid());
 
   // Accept matching question.
   EXPECT_TRUE(resp.InitParse(sizeof(response_data), *query));
+  EXPECT_TRUE(resp.is_valid());
 
   // Check header access.
-  EXPECT_EQ(0x81, resp.flags0());
-  EXPECT_EQ(0x80, resp.flags1());
+  EXPECT_EQ(0x8180, resp.flags());
   EXPECT_EQ(0x0, resp.rcode());
   EXPECT_EQ(2, resp.answer_count());
 
+  // Check question access.
+  EXPECT_EQ(query->qname(), resp.qname());
+  EXPECT_EQ(query->qtype(), resp.qtype());
+  EXPECT_EQ("codereview.chromium.org", resp.GetDottedName());
+
   DnsResourceRecord record;
   DnsRecordParser parser = resp.Parser();
   EXPECT_TRUE(parser.ParseRecord(&record));
   EXPECT_TRUE(parser.ParseRecord(&record));
   EXPECT_FALSE(parser.ParseRecord(&record));
 }
 
 }  // namespace
 
 }  // namespace net