Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6028)

Unified Diff: client/dom/scripts/dartgenerator.py

Issue 9188062: Make wrapping system use interfaces, not other way round. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: comment Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | client/dom/templates/dom/interface/wrapping_dom.darttemplate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/dom/scripts/dartgenerator.py
diff --git a/client/dom/scripts/dartgenerator.py b/client/dom/scripts/dartgenerator.py
index 6efa4c1cb04da4185be8af8891544ac3d4039ab4..76b8dc7651369875a8b2625659854a75fbba1277 100755
--- a/client/dom/scripts/dartgenerator.py
+++ b/client/dom/scripts/dartgenerator.py
@@ -431,8 +431,9 @@ class DartGenerator(object):
TemplateLoader('../templates', ['dom/wrapping', 'dom', '']),
self._database, self._emitters, self._output_dir)
- # Makes wrapper implementations available for listing in interface lib.
- interface_system._implementation_system = wrapping_system
+ # Makes interface files available for listing in the library for the
+ # wrapping implementation.
+ wrapping_system._interface_system = interface_system
frog_system = FrogSystem(
TemplateLoader('../templates', ['dom/frog', 'dom', '']),
@@ -1018,16 +1019,7 @@ class WrappingInterfacesSystem(System):
self._ProcessCallback(interface, info, file_path)
def GenerateLibraries(self, lib_dir):
- # Library generated for implementation.
- self._GenerateLibFile(
- 'wrapping_dom.darttemplate',
- os.path.join(lib_dir, 'wrapping_dom.dart'),
- (self._dart_interface_file_paths +
- self._dart_callback_file_paths +
- # FIXME: Move the implementation to a separate
- # library.
- self._implementation_system._dart_wrapping_file_paths
- ))
+ pass
def _FilePathForDartInterface(self, interface_name):
@@ -1085,7 +1077,16 @@ class WrappingImplementationSystem(System):
pass
def GenerateLibraries(self, lib_dir):
- pass
+ # Library generated for implementation.
+ self._GenerateLibFile(
+ 'wrapping_dom.darttemplate',
+ os.path.join(lib_dir, 'wrapping_dom.dart'),
+ (self._interface_system._dart_interface_file_paths +
+ self._interface_system._dart_callback_file_paths +
+ # FIXME: Move the implementation to a separate library.
+ self._dart_wrapping_file_paths
+ ))
+
def Finish(self):
self._GenerateJavaScriptExternsWrapping(self._database, self._output_dir)
« no previous file with comments | « no previous file | client/dom/templates/dom/interface/wrapping_dom.darttemplate » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698