Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Unified Diff: chrome/browser/ui/webui/options2/options_ui2.cc

Issue 9188056: Start splitting out WebUI into an implementation class and an interface that each page implements... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/options2/options_ui2.h ('k') | chrome/browser/ui/webui/plugins_ui.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/options2/options_ui2.cc
===================================================================
--- chrome/browser/ui/webui/options2/options_ui2.cc (revision 117388)
+++ chrome/browser/ui/webui/options2/options_ui2.cc (working copy)
@@ -196,7 +196,7 @@
////////////////////////////////////////////////////////////////////////////////
OptionsUI::OptionsUI(WebContents* contents)
- : WebUI(contents),
+ : WebUI(contents, this),
initialized_handlers_(false) {
DictionaryValue* localized_strings = new DictionaryValue();
@@ -295,15 +295,12 @@
}
}
-// Override.
void OptionsUI::RenderViewCreated(RenderViewHost* render_view_host) {
SetCommandLineString(render_view_host);
- WebUI::RenderViewCreated(render_view_host);
}
void OptionsUI::RenderViewReused(RenderViewHost* render_view_host) {
SetCommandLineString(render_view_host);
- WebUI::RenderViewReused(render_view_host);
}
void OptionsUI::DidBecomeActiveForReusedRenderView() {
@@ -314,8 +311,6 @@
// happens, call reinitializeCore (which is a no-op unless the DOM was already
// initialized).
CallJavascriptFunction("OptionsPage.reinitializeCore");
-
- WebUI::DidBecomeActiveForReusedRenderView();
}
// static
« no previous file with comments | « chrome/browser/ui/webui/options2/options_ui2.h ('k') | chrome/browser/ui/webui/plugins_ui.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698