chrome/browser/ui/webui/html_dialog_ui.h - Issue 9188056: Start splitting out WebUI into an implementation class and an interface that each page implements...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/html_dialog_ui.h

Issue 9188056: Start splitting out WebUI into an implementation class and an interface that each page implements... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/html_dialog_ui.h

===================================================================

--- chrome/browser/ui/webui/html_dialog_ui.h (revision 117388)

+++ chrome/browser/ui/webui/html_dialog_ui.h (working copy)

@@ -11,6 +11,7 @@

#include "base/string16.h"

#include "content/browser/webui/web_ui.h"

+#include "content/public/browser/web_ui_controller.h"

#include "googleurl/src/gurl.h"

#include "ui/base/ui_base_types.h"

#include "ui/gfx/rect.h"

@@ -95,7 +96,7 @@

// there and call it back. This is a bit of a hack to allow the dialog to pass

// its delegate to the Web UI without having nasty accessors on the WebContents.

// The correct design using RVH directly would avoid all of this.

-class HtmlDialogUI : public WebUI {

+class HtmlDialogUI : public WebUI, public content::WebUIController {

public:

struct HtmlDialogParams {

// The URL for the content that will be loaded in the dialog.

@@ -120,7 +121,7 @@

static base::PropertyAccessor<HtmlDialogUIDelegate*>& GetPropertyAccessor();

private:

- // WebUI

+ // WebUIController

virtual void RenderViewCreated(RenderViewHost* render_view_host) OVERRIDE;

// JS message handler.

« no previous file with comments | « chrome/browser/ui/webui/history_ui.cc ('k') | chrome/browser/ui/webui/html_dialog_ui.cc » ('j') | no next file with comments »