chrome/browser/ui/webui/sync_internals_ui.cc - Issue 9188056: Start splitting out WebUI into an implementation class and an interface that each page implements...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/sync_internals_ui.cc

Issue 9188056: Start splitting out WebUI into an implementation class and an interface that each page implements... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/net_internals/net_internals_ui.cc ('K') | « chrome/browser/ui/webui/sync_internals_ui.h ('k') | chrome/browser/ui/webui/sync_promo/sync_promo_ui.h » ('j') | content/browser/webui/web_ui.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/sync_internals_ui.cc

===================================================================

--- chrome/browser/ui/webui/sync_internals_ui.cc (revision 117388)

+++ chrome/browser/ui/webui/sync_internals_ui.cc (working copy)

@@ -73,7 +73,7 @@

} // namespace

SyncInternalsUI::SyncInternalsUI(WebContents* contents)

- : WebUI(contents),

+ : WebUI(contents, this),

weak_ptr_factory_(ALLOW_THIS_IN_INITIALIZER_LIST(this)) {

// TODO(akalin): Fix.

Profile* profile = Profile::FromBrowserContext(contents->GetBrowserContext());

@@ -94,9 +94,11 @@

}

-void SyncInternalsUI::OnWebUISend(const GURL& source_url,

- const std::string& name,

- const ListValue& content) {

+void SyncInternalsUI::HandleWebUIMessage(const GURL& source_url,

+ const std::string& name,

+ const ListValue& content,

+ bool* overridden) {

+ *overridden = true;

scoped_ptr<ListValue> content_copy(content.DeepCopy());

JsArgList args(content_copy.get());

VLOG(1) << "Received message: " << name << " with args "