Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: frog/member.dart

Issue 9188048: fix issue 1110 (handle void better) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: comment fix Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | frog/minfrog » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/member.dart
diff --git a/frog/member.dart b/frog/member.dart
index d0c7e64840df33391d958e0e853cc9928b79295f..e12dd0bf042a96137d328f228f7ff3b37e9e89fb 100644
--- a/frog/member.dart
+++ b/frog/member.dart
@@ -1235,7 +1235,8 @@ class MethodMember extends Member {
if (isConstructor && !isFactory) {
returnType = declaringType;
} else {
- returnType = resolveType(definition.returnType, false);
+ // This is the one and only place we allow void.
+ returnType = resolveType(definition.returnType, false, allowVoid: true);
}
parameters = [];
for (var formal in definition.formals) {
@@ -1251,11 +1252,15 @@ class MethodMember extends Member {
}
/** Overriden to ensure that type arguments aren't used in static methods. */
- Type resolveType(TypeReference node, bool typeErrors) {
+ Type resolveType(TypeReference node, bool typeErrors,
+ [bool allowVoid = false]) {
Type t = super.resolveType(node, typeErrors);
if (isStatic && !isFactory && t is ParameterType) {
world.error('using type parameter in static context.', node.span);
}
+ if (!allowVoid && t.isVoid) {
+ world.error('"void" only allowed as return type', node.span);
+ }
return t;
}
}
« no previous file with comments | « no previous file | frog/minfrog » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698