Cleanup: Rename is_hsts_host to fatal.

net/url_request/url_request_test_util.h

Index: net/url_request/url_request_test_util.h
===================================================================
--- net/url_request/url_request_test_util.h	(revision 117302)
+++ net/url_request/url_request_test_util.h	(working copy)
@@ -120,7 +120,7 @@
   }
   bool request_failed() const { return request_failed_; }
   bool have_certificate_errors() const { return have_certificate_errors_; }
-  bool is_hsts_host() const { return is_hsts_host_; }
+  bool fatal() const { return fatal_; }

[wtc, 2012/01/13 01:39:57]

This getter method and the data member should be named
certificate_errors_are_fatal to clarify what is fatal.
(This class, TestDelegate, is not specific to certificate
errors.)

Note the existing members allow_certificate_errors_ and
have_certificate_errors_.  I think it is confusing to have
both allow_certificate_errors_ and certificate_errors_are_fatal.
Please see if we can somehow combine the two, or document
their relation.

[palmer, 2012/01/13 23:03:47]

Done.

   bool auth_required_called() const { return auth_required_; }
 
   // net::URLRequest::Delegate:
@@ -130,7 +130,7 @@
                               net::AuthChallengeInfo* auth_info) OVERRIDE;
   virtual void OnSSLCertificateError(net::URLRequest* request,
                                      const net::SSLInfo& ssl_info,
-                                     bool is_hsts_host) OVERRIDE;
+                                     bool fatal) OVERRIDE;

[wtc, 2012/01/13 01:39:57]

In contrast, this input parameter to a function handling
SSL certificate error can be named simply 'fatal' because
the context makes it clear what is fatal.

[palmer, 2012/01/13 23:03:47]

Done.

   virtual bool CanGetCookies(const net::URLRequest* request,
                              const net::CookieList& cookie_list) const OVERRIDE;
   virtual bool CanSetCookie(const net::URLRequest* request,
@@ -166,7 +166,7 @@
   bool received_data_before_response_;
   bool request_failed_;
   bool have_certificate_errors_;
-  bool is_hsts_host_;
+  bool fatal_;
   bool auth_required_;
   std::string data_received_;