Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 9188012: bots: include webdriver tests in bots. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: '' Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/test_options.dart ('k') | utils/tests/css/css.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index 5a0207a4ec99441794143b234325c3167e8d2745..426f86baea4871182fc9d38d9261325be208e56d 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -460,27 +460,7 @@ class StandardTestSuite implements TestSuite {
List<String> args;
if (component == 'webdriver') {
executable = '$dartDir/tools/testing/run_selenium.py';
- String browserFlag = 'chrome';
- if (configuration['flag'] != null) {
- for (var flag in configuration['flag'].split(',')) {
- switch (flag) {
- case 'ff':
- case 'firefox':
- browserFlag = 'ff';
- break;
- case 'ie':
- case 'explorer':
- case 'internet-explorer':
- browserFlag = 'ie';
- break;
- case 'safari':
- browserFlag = 'safari';
- break;
- }
- }
- }
- args = ['--out', htmlPath, '--browser', browserFlag];
-
+ args = ['--out', htmlPath, '--browser', configuration['browser']];
} else {
args = ['--no-timeout'];
if (component == 'dartium') {
« no previous file with comments | « tools/testing/dart/test_options.dart ('k') | utils/tests/css/css.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698