Issue 9188: Make better (and more efficient) use of Hammer functionality...

Issue 9188: Make better (and more efficient) use of Hammer functionality... (Closed)

Created:
12 years, 1 month ago by sgk

Modified:
9 years, 5 months ago

Reviewers:
tony, bradn

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make better (and more efficient) use of Hammer functionality in base, net and sandbox: * Remove by-hand Install() and Alias() calls. * Set $COMPONENT_PROGRAM_GROUPS and $COMPONENT_TEST_PROGRAM_GROUPS (with in each foo\foo.scons file) so executables get added automatically to the appropriate Alias. * Set $TESTS_DIR and $STAGING_DIR so executables get linked directly in their final resting place ($TARGET_ROOT). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=4805

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -41 lines)			Patch
M	base/base.scons	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	base/base_lib.scons	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	base/base_unittests.scons	View	1 chunk	+1 line, -6 lines	0 comments	Download
M	build/SConscript.main	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	build/googleurl.scons	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	net/crash_cache.scons	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	net/net.scons	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	net/net_perftests.scons	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	net/net_resources.scons	View	1 chunk	+1 line, -1 line	2 comments	Download
M	net/net_unittests.scons	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	net/stress_cache.scons	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	net/tools/tld_cleanup/tld_cleanup.scons	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	sandbox/sandbox.scons	View	1 chunk	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bradn

LGTM http://codereview.chromium.org/9188/diff/1/5 File net/net_resources.scons (right): http://codereview.chromium.org/9188/diff/1/5#newcode41 Line 41: #env.Alias('net', net_resources) Can't this go away?

12 years, 1 month ago (2008-11-05 19:25:43 UTC) #2

sgk

http://codereview.chromium.org/9188/diff/1/5 File net/net_resources.scons (right): http://codereview.chromium.org/9188/diff/1/5#newcode41 Line 41: #env.Alias('net', net_resources) On 2008/11/05 19:25:43, bradn wrote: > ...

12 years, 1 month ago (2008-11-05 19:29:35 UTC) #3

tony

12 years, 1 month ago (2008-11-05 19:35:45 UTC) #4

nice, lgtm.

On 2008/11/05 19:29:35, sgk wrote:
> http://codereview.chromium.org/9188/diff/1/5
> File net/net_resources.scons (right):
> 
> http://codereview.chromium.org/9188/diff/1/5#newcode41
> Line 41: #env.Alias('net', net_resources)
> On 2008/11/05 19:25:43, bradn wrote:
> > Can't this go away?
> 
> Done.

Expand Messages | Collapse Messages